Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/ic/ic.cc

Issue 2549773002: Internalize strings in-place (Closed)
Patch Set: forgot one Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/ia32/code-stubs-ia32.cc ('K') | « src/ic/accessor-assembler.cc ('k') | src/ic/keyed-store-generic.cc » ('j') | src/objects.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic/ic.cc
diff --git a/src/ic/ic.cc b/src/ic/ic.cc
index ddc6b1a7df213cbb2eee02b9d30aa4fd51e78cac..3718ddc36b58329956c13a0222e7454141b79f0b 100644
--- a/src/ic/ic.cc
+++ b/src/ic/ic.cc
@@ -1631,6 +1631,8 @@ static Handle<Object> TryConvertKey(Handle<Object> key, Isolate* isolate) {
}
} else if (key->IsUndefined(isolate)) {
key = isolate->factory()->undefined_string();
+ } else if (key->IsString()) {
+ key = isolate->factory()->InternalizeString(Handle<String>::cast(key));
}
return key;
}
« src/ia32/code-stubs-ia32.cc ('K') | « src/ic/accessor-assembler.cc ('k') | src/ic/keyed-store-generic.cc » ('j') | src/objects.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698