Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Side by Side Diff: src/x87/code-stubs-x87.cc

Issue 2549773002: Internalize strings in-place (Closed)
Patch Set: rebased Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/macro-assembler-x64.cc ('k') | src/x87/codegen-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/code-stubs.h" 7 #include "src/code-stubs.h"
8 #include "src/api-arguments.h" 8 #include "src/api-arguments.h"
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 407 matching lines...) Expand 10 before | Expand all | Expand 10 after
418 // (5) One byte sequential. Load regexp code for one byte. 418 // (5) One byte sequential. Load regexp code for one byte.
419 // (E) Carry on. 419 // (E) Carry on.
420 /// [...] 420 /// [...]
421 421
422 // Deferred code at the end of the stub: 422 // Deferred code at the end of the stub:
423 // (6) Long external string? If not, go to (10). 423 // (6) Long external string? If not, go to (10).
424 // (7) External string. Make it, offset-wise, look like a sequential string. 424 // (7) External string. Make it, offset-wise, look like a sequential string.
425 // (8) Is the external string one byte? If yes, go to (5). 425 // (8) Is the external string one byte? If yes, go to (5).
426 // (9) Two byte sequential. Load regexp code for two byte. Go to (E). 426 // (9) Two byte sequential. Load regexp code for two byte. Go to (E).
427 // (10) Short external string or not a string? If yes, bail out to runtime. 427 // (10) Short external string or not a string? If yes, bail out to runtime.
428 // (11) Sliced string. Replace subject with parent. Go to (1). 428 // (11) Sliced or thin string. Replace subject with parent. Go to (1).
429 429
430 Label seq_one_byte_string /* 5 */, seq_two_byte_string /* 9 */, 430 Label seq_one_byte_string /* 5 */, seq_two_byte_string /* 9 */,
431 external_string /* 7 */, check_underlying /* 1 */, 431 external_string /* 7 */, check_underlying /* 1 */,
432 not_seq_nor_cons /* 6 */, check_code /* E */, not_long_external /* 10 */; 432 not_seq_nor_cons /* 6 */, check_code /* E */, not_long_external /* 10 */;
433 433
434 __ bind(&check_underlying); 434 __ bind(&check_underlying);
435 // (1) Sequential two byte? If yes, go to (9). 435 // (1) Sequential two byte? If yes, go to (9).
436 __ mov(ebx, FieldOperand(eax, HeapObject::kMapOffset)); 436 __ mov(ebx, FieldOperand(eax, HeapObject::kMapOffset));
437 __ movzx_b(ebx, FieldOperand(ebx, Map::kInstanceTypeOffset)); 437 __ movzx_b(ebx, FieldOperand(ebx, Map::kInstanceTypeOffset));
438 438
439 __ and_(ebx, kIsNotStringMask | 439 __ and_(ebx, kIsNotStringMask |
440 kStringRepresentationMask | 440 kStringRepresentationMask |
441 kStringEncodingMask | 441 kStringEncodingMask |
442 kShortExternalStringMask); 442 kShortExternalStringMask);
443 STATIC_ASSERT((kStringTag | kSeqStringTag | kTwoByteStringTag) == 0); 443 STATIC_ASSERT((kStringTag | kSeqStringTag | kTwoByteStringTag) == 0);
444 __ j(zero, &seq_two_byte_string); // Go to (9). 444 __ j(zero, &seq_two_byte_string); // Go to (9).
445 445
446 // (2) Sequential one byte? If yes, go to (5). 446 // (2) Sequential one byte? If yes, go to (5).
447 // Any other sequential string must be one byte. 447 // Any other sequential string must be one byte.
448 __ and_(ebx, Immediate(kIsNotStringMask | 448 __ and_(ebx, Immediate(kIsNotStringMask |
449 kStringRepresentationMask | 449 kStringRepresentationMask |
450 kShortExternalStringMask)); 450 kShortExternalStringMask));
451 __ j(zero, &seq_one_byte_string, Label::kNear); // Go to (5). 451 __ j(zero, &seq_one_byte_string, Label::kNear); // Go to (5).
452 452
453 // (3) Sequential or cons? If not, go to (6). 453 // (3) Sequential or cons? If not, go to (6).
454 // We check whether the subject string is a cons, since sequential strings 454 // We check whether the subject string is a cons, since sequential strings
455 // have already been covered. 455 // have already been covered.
456 STATIC_ASSERT(kConsStringTag < kExternalStringTag); 456 STATIC_ASSERT(kConsStringTag < kExternalStringTag);
457 STATIC_ASSERT(kSlicedStringTag > kExternalStringTag); 457 STATIC_ASSERT(kSlicedStringTag > kExternalStringTag);
458 STATIC_ASSERT(kThinStringTag > kExternalStringTag);
458 STATIC_ASSERT(kIsNotStringMask > kExternalStringTag); 459 STATIC_ASSERT(kIsNotStringMask > kExternalStringTag);
459 STATIC_ASSERT(kShortExternalStringTag > kExternalStringTag); 460 STATIC_ASSERT(kShortExternalStringTag > kExternalStringTag);
460 __ cmp(ebx, Immediate(kExternalStringTag)); 461 __ cmp(ebx, Immediate(kExternalStringTag));
461 __ j(greater_equal, &not_seq_nor_cons); // Go to (6). 462 __ j(greater_equal, &not_seq_nor_cons); // Go to (6).
462 463
463 // (4) Cons string. Check that it's flat. 464 // (4) Cons string. Check that it's flat.
464 // Replace subject with first string and reload instance type. 465 // Replace subject with first string and reload instance type.
465 __ cmp(FieldOperand(eax, ConsString::kSecondOffset), factory->empty_string()); 466 __ cmp(FieldOperand(eax, ConsString::kSecondOffset), factory->empty_string());
466 __ j(not_equal, &runtime); 467 __ j(not_equal, &runtime);
467 __ mov(eax, FieldOperand(eax, ConsString::kFirstOffset)); 468 __ mov(eax, FieldOperand(eax, ConsString::kFirstOffset));
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
726 __ Move(ecx, Immediate(0)); // Type is two byte. 727 __ Move(ecx, Immediate(0)); // Type is two byte.
727 __ jmp(&check_code); // Go to (E). 728 __ jmp(&check_code); // Go to (E).
728 729
729 // (10) Not a string or a short external string? If yes, bail out to runtime. 730 // (10) Not a string or a short external string? If yes, bail out to runtime.
730 __ bind(&not_long_external); 731 __ bind(&not_long_external);
731 // Catch non-string subject or short external string. 732 // Catch non-string subject or short external string.
732 STATIC_ASSERT(kNotStringTag != 0 && kShortExternalStringTag !=0); 733 STATIC_ASSERT(kNotStringTag != 0 && kShortExternalStringTag !=0);
733 __ test(ebx, Immediate(kIsNotStringMask | kShortExternalStringTag)); 734 __ test(ebx, Immediate(kIsNotStringMask | kShortExternalStringTag));
734 __ j(not_zero, &runtime); 735 __ j(not_zero, &runtime);
735 736
736 // (11) Sliced string. Replace subject with parent. Go to (1). 737 // (11) Sliced or thin string. Replace subject with parent. Go to (1).
738 Label thin_string;
739 __ cmp(ebx, Immediate(kThinStringTag));
740 __ j(equal, &thin_string, Label::kNear);
737 // Load offset into edi and replace subject string with parent. 741 // Load offset into edi and replace subject string with parent.
738 __ mov(edi, FieldOperand(eax, SlicedString::kOffsetOffset)); 742 __ mov(edi, FieldOperand(eax, SlicedString::kOffsetOffset));
739 __ mov(eax, FieldOperand(eax, SlicedString::kParentOffset)); 743 __ mov(eax, FieldOperand(eax, SlicedString::kParentOffset));
740 __ jmp(&check_underlying); // Go to (1). 744 __ jmp(&check_underlying); // Go to (1).
745
746 __ bind(&thin_string);
747 __ mov(eax, FieldOperand(eax, ThinString::kActualOffset));
748 __ jmp(&check_underlying); // Go to (1).
741 #endif // V8_INTERPRETED_REGEXP 749 #endif // V8_INTERPRETED_REGEXP
742 } 750 }
743 751
744 752
745 static int NegativeComparisonResult(Condition cc) { 753 static int NegativeComparisonResult(Condition cc) {
746 DCHECK(cc != equal); 754 DCHECK(cc != equal);
747 DCHECK((cc == less) || (cc == less_equal) 755 DCHECK((cc == less) || (cc == less_equal)
748 || (cc == greater) || (cc == greater_equal)); 756 || (cc == greater) || (cc == greater_equal));
749 return (cc == greater || cc == greater_equal) ? LESS : GREATER; 757 return (cc == greater || cc == greater_equal) ? LESS : GREATER;
750 } 758 }
(...skipping 3246 matching lines...) Expand 10 before | Expand all | Expand 10 after
3997 kStackUnwindSpace, nullptr, return_value_operand, 4005 kStackUnwindSpace, nullptr, return_value_operand,
3998 NULL); 4006 NULL);
3999 } 4007 }
4000 4008
4001 #undef __ 4009 #undef __
4002 4010
4003 } // namespace internal 4011 } // namespace internal
4004 } // namespace v8 4012 } // namespace v8
4005 4013
4006 #endif // V8_TARGET_ARCH_X87 4014 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/x64/macro-assembler-x64.cc ('k') | src/x87/codegen-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698