Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: src/profiler/heap-snapshot-generator.cc

Issue 2549773002: Internalize strings in-place (Closed)
Patch Set: fix performance Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/profiler/heap-snapshot-generator.h" 5 #include "src/profiler/heap-snapshot-generator.h"
6 6
7 #include "src/code-stubs.h" 7 #include "src/code-stubs.h"
8 #include "src/conversions.h" 8 #include "src/conversions.h"
9 #include "src/debug/debug.h" 9 #include "src/debug/debug.h"
10 #include "src/objects-body-descriptors.h" 10 #include "src/objects-body-descriptors.h"
(...skipping 1147 matching lines...) Expand 10 before | Expand all | Expand 10 after
1158 if (string->IsConsString()) { 1158 if (string->IsConsString()) {
1159 ConsString* cs = ConsString::cast(string); 1159 ConsString* cs = ConsString::cast(string);
1160 SetInternalReference(cs, entry, "first", cs->first(), 1160 SetInternalReference(cs, entry, "first", cs->first(),
1161 ConsString::kFirstOffset); 1161 ConsString::kFirstOffset);
1162 SetInternalReference(cs, entry, "second", cs->second(), 1162 SetInternalReference(cs, entry, "second", cs->second(),
1163 ConsString::kSecondOffset); 1163 ConsString::kSecondOffset);
1164 } else if (string->IsSlicedString()) { 1164 } else if (string->IsSlicedString()) {
1165 SlicedString* ss = SlicedString::cast(string); 1165 SlicedString* ss = SlicedString::cast(string);
1166 SetInternalReference(ss, entry, "parent", ss->parent(), 1166 SetInternalReference(ss, entry, "parent", ss->parent(),
1167 SlicedString::kParentOffset); 1167 SlicedString::kParentOffset);
1168 } else if (string->IsThinString()) {
1169 ThinString* ts = ThinString::cast(string);
1170 SetInternalReference(ts, entry, "actual", ts->actual(),
1171 ThinString::kActualOffset);
1168 } 1172 }
1169 } 1173 }
1170 1174
1171 1175
1172 void V8HeapExplorer::ExtractSymbolReferences(int entry, Symbol* symbol) { 1176 void V8HeapExplorer::ExtractSymbolReferences(int entry, Symbol* symbol) {
1173 SetInternalReference(symbol, entry, 1177 SetInternalReference(symbol, entry,
1174 "name", symbol->name(), 1178 "name", symbol->name(),
1175 Symbol::kNameOffset); 1179 Symbol::kNameOffset);
1176 } 1180 }
1177 1181
(...skipping 1933 matching lines...) Expand 10 before | Expand all | Expand 10 after
3111 for (int i = 1; i < sorted_strings.length(); ++i) { 3115 for (int i = 1; i < sorted_strings.length(); ++i) {
3112 writer_->AddCharacter(','); 3116 writer_->AddCharacter(',');
3113 SerializeString(sorted_strings[i]); 3117 SerializeString(sorted_strings[i]);
3114 if (writer_->aborted()) return; 3118 if (writer_->aborted()) return;
3115 } 3119 }
3116 } 3120 }
3117 3121
3118 3122
3119 } // namespace internal 3123 } // namespace internal
3120 } // namespace v8 3124 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698