Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/compiler/types.cc

Issue 2549773002: Internalize strings in-place (Closed)
Patch Set: fix performance Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <iomanip> 5 #include <iomanip>
6 6
7 #include "src/compiler/types.h" 7 #include "src/compiler/types.h"
8 8
9 #include "src/handles-inl.h" 9 #include "src/handles-inl.h"
10 #include "src/objects-inl.h" 10 #include "src/objects-inl.h"
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 return kNone; 145 return kNone;
146 } 146 }
147 147
148 Type::bitset BitsetType::Lub(i::Map* map) { 148 Type::bitset BitsetType::Lub(i::Map* map) {
149 DisallowHeapAllocation no_allocation; 149 DisallowHeapAllocation no_allocation;
150 switch (map->instance_type()) { 150 switch (map->instance_type()) {
151 case STRING_TYPE: 151 case STRING_TYPE:
152 case ONE_BYTE_STRING_TYPE: 152 case ONE_BYTE_STRING_TYPE:
153 case CONS_STRING_TYPE: 153 case CONS_STRING_TYPE:
154 case CONS_ONE_BYTE_STRING_TYPE: 154 case CONS_ONE_BYTE_STRING_TYPE:
155 case THIN_STRING_TYPE:
156 case THIN_ONE_BYTE_STRING_TYPE:
155 case SLICED_STRING_TYPE: 157 case SLICED_STRING_TYPE:
156 case SLICED_ONE_BYTE_STRING_TYPE: 158 case SLICED_ONE_BYTE_STRING_TYPE:
157 case EXTERNAL_STRING_TYPE: 159 case EXTERNAL_STRING_TYPE:
158 case EXTERNAL_ONE_BYTE_STRING_TYPE: 160 case EXTERNAL_ONE_BYTE_STRING_TYPE:
159 case EXTERNAL_STRING_WITH_ONE_BYTE_DATA_TYPE: 161 case EXTERNAL_STRING_WITH_ONE_BYTE_DATA_TYPE:
160 case SHORT_EXTERNAL_STRING_TYPE: 162 case SHORT_EXTERNAL_STRING_TYPE:
161 case SHORT_EXTERNAL_ONE_BYTE_STRING_TYPE: 163 case SHORT_EXTERNAL_ONE_BYTE_STRING_TYPE:
162 case SHORT_EXTERNAL_STRING_WITH_ONE_BYTE_DATA_TYPE: 164 case SHORT_EXTERNAL_STRING_WITH_ONE_BYTE_DATA_TYPE:
163 return kOtherString; 165 return kOtherString;
164 case INTERNALIZED_STRING_TYPE: 166 case INTERNALIZED_STRING_TYPE:
(...skipping 897 matching lines...) Expand 10 before | Expand all | Expand 10 after
1062 return i::SmiValuesAre31Bits() ? kSigned31 : kSigned32; 1064 return i::SmiValuesAre31Bits() ? kSigned31 : kSigned32;
1063 } 1065 }
1064 1066
1065 BitsetType::bitset BitsetType::UnsignedSmall() { 1067 BitsetType::bitset BitsetType::UnsignedSmall() {
1066 return i::SmiValuesAre31Bits() ? kUnsigned30 : kUnsigned31; 1068 return i::SmiValuesAre31Bits() ? kUnsigned30 : kUnsigned31;
1067 } 1069 }
1068 1070
1069 } // namespace compiler 1071 } // namespace compiler
1070 } // namespace internal 1072 } // namespace internal
1071 } // namespace v8 1073 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698