Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2549743002: VM: Fix DBC out-of-bounds load from Uint32List. (Closed)

Created:
4 years ago by Florian Schneider
Modified:
4 years ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Fix DBC out-of-bounds load from Uint32List. Fixes #27849. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/10e08360c7f07ac41b0f16e80ef8f25fdf4fccff

Patch Set 1 #

Total comments: 4

Patch Set 2 : add const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M runtime/vm/simulator_dbc.cc View 1 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Florian Schneider
4 years ago (2016-12-02 04:29:03 UTC) #2
zra
Doh! I was staring at this all morning and didn't see it. Thanks! lgtm https://codereview.chromium.org/2549743002/diff/1/runtime/vm/simulator_dbc.cc ...
4 years ago (2016-12-02 05:07:53 UTC) #3
Florian Schneider
Same here. I was looking at the wrong places for so long... https://codereview.chromium.org/2549743002/diff/1/runtime/vm/simulator_dbc.cc File runtime/vm/simulator_dbc.cc ...
4 years ago (2016-12-02 18:35:02 UTC) #4
Florian Schneider
4 years ago (2016-12-02 18:43:29 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
10e08360c7f07ac41b0f16e80ef8f25fdf4fccff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698