Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 2549683002: Mojo JS bindings: introduce concepts that are more similar to C++ bindings: (Closed)

Created:
4 years ago by yzshen1
Modified:
4 years ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo JS bindings: introduce concepts that are more similar to C++ bindings: - InterfacePtrInfo - InterfaceRequest - InterfacePtr - Binding BUG=579646 Committed: https://crrev.com/5f3032e780d840cb59233978f457f76225336a3f Cr-Commit-Position: refs/heads/master@{#436201}

Patch Set 1 #

Total comments: 2

Patch Set 2 : put interface control methods in the |ptr| property #

Unified diffs Side-by-side diffs Delta from patch set Stats (+420 lines, -99 lines) Patch
M mojo/edk/js/test/run_js_integration_tests.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M mojo/edk/js/tests/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A mojo/edk/js/tests/binding_tests.js View 1 1 chunk +80 lines, -0 lines 0 comments Download
A mojo/edk/js/tests/interface_ptr_tests.js View 1 1 chunk +102 lines, -0 lines 0 comments Download
M mojo/edk/js/tests/sample_service_tests.js View 1 2 chunks +8 lines, -12 lines 0 comments Download
M mojo/public/js/bindings.js View 1 1 chunk +104 lines, -79 lines 0 comments Download
M mojo/public/js/connection.js View 2 chunks +104 lines, -6 lines 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl View 1 1 chunk +9 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/module_definition.tmpl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks! https://codereview.chromium.org/2549683002/diff/1/mojo/public/js/connection.js File mojo/public/js/connection.js (right): https://codereview.chromium.org/2549683002/diff/1/mojo/public/js/connection.js#newcode15 mojo/public/js/connection.js:15: ...
4 years ago (2016-12-02 00:22:59 UTC) #4
Ken Rockot(use gerrit already)
LGTM as-is, but I have an optional suggestion for your consideration: Instead of a treating ...
4 years ago (2016-12-02 02:42:40 UTC) #7
yzshen1
On 2016/12/02 02:42:40, Ken Rockot wrote: > LGTM as-is, but I have an optional suggestion ...
4 years ago (2016-12-02 16:34:22 UTC) #8
Ken Rockot(use gerrit already)
On Fri, Dec 2, 2016 at 8:34 AM, <yzshen@chromium.org> wrote: > On 2016/12/02 02:42:40, Ken ...
4 years ago (2016-12-02 16:40:33 UTC) #9
yzshen1
On 2016/12/02 16:34:22, yzshen1 wrote: > On 2016/12/02 02:42:40, Ken Rockot wrote: > > LGTM ...
4 years ago (2016-12-02 16:45:13 UTC) #10
yzshen1
On 2016/12/02 16:40:33, Ken Rockot wrote: > On Fri, Dec 2, 2016 at 8:34 AM, ...
4 years ago (2016-12-02 17:14:04 UTC) #11
yzshen1
Updated the CL as suggested. PTAL. Thanks!
4 years ago (2016-12-02 17:42:08 UTC) #12
Ken Rockot(use gerrit already)
LGTM! Options I can see for addressing the binding circular refs: - What we do ...
4 years ago (2016-12-02 18:17:52 UTC) #13
yzshen1
On 2016/12/02 18:17:52, Ken Rockot wrote: > LGTM! > > Options I can see for ...
4 years ago (2016-12-02 23:40:15 UTC) #14
Ken Rockot(use gerrit already)
Oh, I definitely didn't mean that we should do anything more in this CL. Still ...
4 years ago (2016-12-02 23:41:23 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2549683002/20001
4 years ago (2016-12-04 19:14:05 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-04 20:23:06 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-04 20:25:27 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5f3032e780d840cb59233978f457f76225336a3f
Cr-Commit-Position: refs/heads/master@{#436201}

Powered by Google App Engine
This is Rietveld 408576698