Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 254963003: Revert of GestureRecognizerTest tests both Aura and Unified Gesture Detectors. (Closed)

Created:
6 years, 8 months ago by tapted
Modified:
6 years, 8 months ago
Reviewers:
sadrul, tdresser
CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank
Visibility:
Public.

Description

Revert of GestureRecognizerTest tests both Aura and Unified Gesture Detectors. (https://codereview.chromium.org/258633005/) Reason for revert: Breaks compile on http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29%2832%29/builds/23390 ../../ui/aura/gestures/gesture_recognizer_unittest.cc: In constructor 'aura::test::{anonymous}::GestureEventConsumeDelegate::GestureEventConsumeDelegate()': ../../ui/aura/gestures/gesture_recognizer_unittest.cc:354:17: error: 'aura::test::{anonymous}::GestureEventConsumeDelegate::wait_until_event_' will be initialized after [-Werror=reorder] ../../ui/aura/gestures/gesture_recognizer_unittest.cc:352:7: error: 'int aura::test::{anonymous}::GestureEventConsumeDelegate::flags_' [-Werror=reorder] ../../ui/aura/gestures/gesture_recognizer_unittest.cc:70:3: error: when initialized here [-Werror=reorder] Original issue's description: > GestureRecognizerTest tests both Aura and Unified Gesture Detectors. > > This is in preparation of landing the unified GR > (see https://codereview.chromium.org/251543003/). > > There are some cases where behavior differs in minor ways. > > This is sometimes dealt with by increasing the test's margin of error > (for instance, slop handling is slightly different, so we now > exceed the slop more thoroughly). > > This is sometimes dealt with by ignoring the test if the test is > run with the unified GR. > > BUG=332418 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266440 TBR=sadrul@chromium.org,tdresser@chromium.org NOTREECHECKS=true NOTRY=true BUG=332418 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266443

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -272 lines) Patch
M ui/aura/gestures/gesture_recognizer_unittest.cc View 81 chunks +114 lines, -271 lines 0 comments Download
M ui/aura/test/aura_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
tapted
Created Revert of GestureRecognizerTest tests both Aura and Unified Gesture Detectors.
6 years, 8 months ago (2014-04-28 06:17:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/254963003/1
6 years, 8 months ago (2014-04-28 06:19:16 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-28 06:20:16 UTC) #3
Message was sent while issue was closed.
Change committed as 266443

Powered by Google App Engine
This is Rietveld 408576698