Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2549613002: Remove old AST factory constructors from analyzer. (Closed)

Created:
4 years ago by Paul Berry
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove old AST factory constructors from analyzer. This reapplies the remainder of 1d028eed8dfa00ac9d4ff685e61b01e6909dbeb4 (which was reverted due to conflicts with dev_compiler), since dev_compiler has now been fixed to use analyzer's new astFactory. R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/c4f50f53cb68f4e7296c45100f8df4cbf07ba89d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1239 lines) Patch
M pkg/analyzer/CHANGELOG.md View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/dart/ast/ast.dart View 112 chunks +3 lines, -1239 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years ago (2016-12-01 19:04:08 UTC) #2
Brian Wilkerson
lgtm
4 years ago (2016-12-01 19:06:20 UTC) #3
scheglov
LGTM
4 years ago (2016-12-01 19:08:57 UTC) #4
Paul Berry
4 years ago (2016-12-01 19:17:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c4f50f53cb68f4e7296c45100f8df4cbf07ba89d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698