Issue 25496002: CC: Fix call order of ScrollOffsetDelegate in ActivatePendingTree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25496002: CC: Fix call order of ScrollOffsetDelegate in ActivatePendingTree. (Closed)

Created:
7 years, 2 months ago by Primiano Tucci (use gerrit)

Modified:
7 years, 2 months ago

Reviewers:
danakj, aelias_OOO_until_Jul13, mkosiba (inactive)

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

CC: Fix call order of ScrollOffsetDelegate in ActivatePendingTree. When a full tree synchronization happens, the ScrollOffsetDelegate is called too early (i.e. before DidBecomeActive()) and sees always a 0x0 scroll offset. This CL swaps the call order of SetRootLayerScrollOffsetDelegate and DidBecomeActive during the active tree activation in LayerTreeHostImpl::ActivatePendingTree. Updating also the unit tests to prevent future regressions on the RootLayerScrollOffsetDelegate. BUG=b/10959756 TBR=mkosiba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226255

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -6 lines)			Patch
	M	cc/trees/layer_tree_host_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	cc/trees/layer_tree_host_impl_unittest.cc	View		4 chunks	+20 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Primiano Tucci (use gerrit)

+danakj : Could you please take a look? Thanks

7 years, 2 months ago (2013-10-01 11:31:51 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/25496002/1

7 years, 2 months ago (2013-10-01 15:06:59 UTC) #4

Message was sent while issue was closed.

Change committed as 226255

Expand Messages | Collapse Messages