Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2549593005: Revert of Place CHECKs to check FontResource::startLoadLimiTimers is called appropriately (Closed)

Created:
4 years ago by Takashi Toyoshima
Modified:
4 years ago
Reviewers:
yhirano
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Place CHECKs to check FontResource::startLoadLimiTimers is called appropriately (patchset #1 id:1 of https://codereview.chromium.org/2544603003/ ) Reason for revert: Confirmed that the DCHECK at line 113 was wrong. Original issue's description: > Place CHECKs to check FontResource::startLoadLimiTimers is called appropriately > > BUG=666227 > > Committed: https://crrev.com/2b57ae8716a7b6e19c1f9928c9c8a4551d472fb2 > Cr-Commit-Position: refs/heads/master@{#435595} TBR=yhirano@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=666227 Committed: https://crrev.com/ec612d746a3124ebcd94b3a5f8f8c0c77e51074d Cr-Commit-Position: refs/heads/master@{#435911}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/Source/core/loader/resource/FontResource.cpp View 3 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Takashi Toyoshima
Created Revert of Place CHECKs to check FontResource::startLoadLimiTimers is called appropriately
4 years ago (2016-12-02 11:10:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2549593005/1
4 years ago (2016-12-02 11:11:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 11:12:04 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-02 11:14:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec612d746a3124ebcd94b3a5f8f8c0c77e51074d
Cr-Commit-Position: refs/heads/master@{#435911}

Powered by Google App Engine
This is Rietveld 408576698