Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2549583004: [url] Early return for finding query/ref parts in path parsing (Closed)

Created:
4 years ago by Charlie Harrison
Modified:
4 years ago
Reviewers:
Mike West
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[url] Early return for finding query/ref parts in path parsing For URLs with huge ref parts (~.5mb), this saves ~18% off of url::ResolveRelative and ~10% off of KURL::init. BUG=657978 Committed: https://crrev.com/ad24ce2f18b3de5e33955675eb4710a6d722236f Cr-Commit-Position: refs/heads/master@{#436593}

Patch Set 1 #

Patch Set 2 : minor code move (trybots prev) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -17 lines) Patch
M url/third_party/mozilla/url_parse.cc View 1 3 chunks +27 lines, -17 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Charlie Harrison
Hey Mike, here's another optimization I noticed. PTAL? I'm not sure how common huge ref ...
4 years ago (2016-12-01 21:52:08 UTC) #5
Mike West
LGTM, sorry for the delayed response!
4 years ago (2016-12-06 13:45:06 UTC) #6
Charlie Harrison
Thanks, no worries!
4 years ago (2016-12-06 13:46:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2549583004/20001
4 years ago (2016-12-06 13:46:55 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-06 14:37:52 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-06 14:41:08 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ad24ce2f18b3de5e33955675eb4710a6d722236f
Cr-Commit-Position: refs/heads/master@{#436593}

Powered by Google App Engine
This is Rietveld 408576698