Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Issue 2549583003: arc: Fix error when uninstalled default app appears in next session. (Closed)

Created:
4 years ago by khmel
Modified:
4 years ago
Reviewers:
xiyuan
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, Matt Giuca
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Fix error when uninstalled default app appears in next session. BUG=b/33252307 BUG=670379 TEST=Manually TEST=Extended unit_tests Committed: https://crrev.com/0010c9335a0d718e03ea3c0112f365a0dd380de2 Cr-Commit-Position: refs/heads/master@{#435731}

Patch Set 1 #

Total comments: 4

Patch Set 2 : comment fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -3 lines) Patch
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 3 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_unittest.cc View 1 3 chunks +33 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
khmel
Hi Xiyuan, PTAL https://codereview.chromium.org/2549583003/diff/1/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc File chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc (right): https://codereview.chromium.org/2549583003/diff/1/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc#newcode966 chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc:966: default_apps_.MaybeMarkPackageUninstalled(package_name, false); Need to mark it ...
4 years ago (2016-12-01 19:01:02 UTC) #2
xiyuan
lgtm https://codereview.chromium.org/2549583003/diff/1/chrome/browser/ui/app_list/arc/arc_app_unittest.cc File chrome/browser/ui/app_list/arc/arc_app_unittest.cc (right): https://codereview.chromium.org/2549583003/diff/1/chrome/browser/ui/app_list/arc/arc_app_unittest.cc#newcode1206 chrome/browser/ui/app_list/arc/arc_app_unittest.cc:1206: // Sing-out and sign-in again. Removed default app ...
4 years ago (2016-12-01 21:11:00 UTC) #3
khmel
Thank you! https://codereview.chromium.org/2549583003/diff/1/chrome/browser/ui/app_list/arc/arc_app_unittest.cc File chrome/browser/ui/app_list/arc/arc_app_unittest.cc (right): https://codereview.chromium.org/2549583003/diff/1/chrome/browser/ui/app_list/arc/arc_app_unittest.cc#newcode1206 chrome/browser/ui/app_list/arc/arc_app_unittest.cc:1206: // Sing-out and sign-in again. Removed default ...
4 years ago (2016-12-01 21:29:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2549583003/20001
4 years ago (2016-12-01 21:30:31 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-01 22:00:48 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-01 22:03:39 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0010c9335a0d718e03ea3c0112f365a0dd380de2
Cr-Commit-Position: refs/heads/master@{#435731}

Powered by Google App Engine
This is Rietveld 408576698