arc: Fix error when uninstalled default app appears in next session.

arc: Fix error when uninstalled default app appears in next session.

BUG=b/33252307
BUG=670379
TEST=Manually
TEST=Extended unit_tests

Committed: https://crrev.com/0010c9335a0d718e03ea3c0112f365a0dd380de2
Cr-Commit-Position: refs/heads/master@{#435731}

[khmel, 2016-12-01 19:01:01]

khmel@chromium.org changed reviewers:
+ xiyuan@chromium.org

[khmel, 2016-12-01 19:01:02]

Hi Xiyuan,

PTAL

https://codereview.chromium.org/2549583003/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc (right):

https://codereview.chromium.org/2549583003/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc:966:
default_apps_.MaybeMarkPackageUninstalled(package_name, false);
Need to mark it once app is reported because as IsOEM is called from app list
once new app appears.

https://codereview.chromium.org/2549583003/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc:1205:
package_info->GetBoolean(kUninstalled, &uninstalled);
Hmm, Cannot explain how I wrote this code before...

[xiyuan, 2016-12-01 21:11:00]

lgtm

https://codereview.chromium.org/2549583003/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/arc/arc_app_unittest.cc (right):

https://codereview.chromium.org/2549583003/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/arc/arc_app_unittest.cc:1206: // Sing-out and sign-in
again. Removed default app should not appear.
nit: Sing-out -> Sign-out

[khmel, 2016-12-01 21:29:59]

Thank you!

https://codereview.chromium.org/2549583003/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/arc/arc_app_unittest.cc (right):

https://codereview.chromium.org/2549583003/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/arc/arc_app_unittest.cc:1206: // Sing-out and sign-in
again. Removed default app should not appear.
On 2016/12/01 21:10:59, xiyuan wrote:
> nit: Sing-out -> Sign-out

Done.

[khmel, 2016-12-01 21:30:01]

The CQ bit was checked by khmel@chromium.org

[khmel, 2016-12-01 21:30:02]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2549583003/#ps20001
(title: "comment fixed")

[commit-bot: I haz the power, 2016-12-01 21:30:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 22:00:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480627801910980,
"parent_rev": "ca479a911f476b5e05b4270d3468233a0f1f290e", "commit_rev":
"e2cea586b6725d4696a05b61405d3ea9bca16a31"}

[commit-bot: I haz the power, 2016-12-01 22:00:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-01 22:03:38]

Description was changed from

==========
arc: Fix error when uninstalled default app appears in next session.

BUG=b/33252307
BUG=670379
TEST=Manually
TEST=Extended unit_tests
==========

to

==========
arc: Fix error when uninstalled default app appears in next session.

BUG=b/33252307
BUG=670379
TEST=Manually
TEST=Extended unit_tests

Committed: https://crrev.com/0010c9335a0d718e03ea3c0112f365a0dd380de2
Cr-Commit-Position: refs/heads/master@{#435731}
==========

[commit-bot: I haz the power, 2016-12-01 22:03:39]

Patchset 2 (id:??) landed as
https://crrev.com/0010c9335a0d718e03ea3c0112f365a0dd380de2
Cr-Commit-Position: refs/heads/master@{#435731}