Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2549573003: Make concrete stream classes private to .cpp, part 4. (Closed)

Created:
4 years ago by Tom Sepez
Modified:
4 years ago
Reviewers:
npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make concrete stream classes private to .cpp, part 4. This one is more complicated because we were using stack-based instances of what should have been a Release()-only type. Committed: https://pdfium.googlesource.com/pdfium/+/fa89a203151c3ea524fc4dfd7167e2a3baf332fa

Patch Set 1 #

Patch Set 2 : release deleter #

Patch Set 3 : comment #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -89 lines) Patch
M fpdfsdk/cpdfsdk_formfillenvironment.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfview.cpp View 2 chunks +69 lines, -40 lines 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp View 1 7 chunks +27 lines, -26 lines 0 comments Download
M fpdfsdk/fsdk_define.h View 1 2 1 chunk +3 lines, -22 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Tom Sepez
NPM, last one.
4 years ago (2016-12-01 23:35:43 UTC) #4
npm
lgtm
4 years ago (2016-12-02 16:05:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2549573003/60001
4 years ago (2016-12-02 17:34:14 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-02 17:48:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/fa89a203151c3ea524fc4dfd7167e2a3baf3...

Powered by Google App Engine
This is Rietveld 408576698