Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2549503003: [HBD] Fix the misleading no-fallback placeholder message in BLOCK mode. (Closed)

Created:
4 years ago by tommycli
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[HBD] Fix the misleading no-fallback placeholder message in BLOCK mode. Previously, if the user had the BLOCK Content Setting (either from Policy or just from user setting), the no-fallback placeholder for HTML5 By Default would still say "Click to enable Flash". This was misleading because that would not work. This updates the BLOCK no-fallback placeholder to say "Flash is blocked" and "Flash is blocked by enterprise policy" (if blocked by policy). BUG=666774 Review-Url: https://codereview.chromium.org/2511263003 Cr-Commit-Position: refs/heads/master@{#435289} (cherry picked from commit e97656b8c9bb4fb2456673f4cd3d8eeb93a65bb8) Committed: https://chromium.googlesource.com/chromium/src/+/ab01d18583ecfd78d9084d66434d77072d7afde1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -19 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.cc View 6 chunks +30 lines, -15 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter_unittest.cc View 5 chunks +53 lines, -0 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tommycli
4 years ago (2016-12-01 18:28:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ab01d18583ecfd78d9084d66434d77072d7afde1.

Powered by Google App Engine
This is Rietveld 408576698