Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 2549493002: Remove unused code for IsFutureStrictReserved. (Closed)

Created:
4 years ago by vogelheim
Modified:
4 years ago
Reviewers:
Toon Verwaest, marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unused code for IsFutureStrictReserved. This apparently gradually fell out of use after the more general Token::IsIdentifer was introduced, and whoever left last forgot to turn out the lights. The only remaining use was in an assertion in DeclareLabel, but meanwhile DeclareLabel is only called if IsIdentifier. I added re-formulated assertions, just in case. R=verwaest@chromium.org BUG=v8:4947 Committed: https://crrev.com/07eca01b73c0f045cf5f54923987c3b91e1d9a7c Cr-Commit-Position: refs/heads/master@{#41452}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -30 lines) Patch
M src/parsing/parser.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/parsing/parser.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/preparser.h View 3 chunks +1 line, -11 lines 0 comments Download
M src/parsing/scanner.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/parsing/scanner.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
vogelheim
ptal
4 years ago (2016-12-01 14:03:54 UTC) #4
vogelheim
4 years ago (2016-12-02 10:49:21 UTC) #8
marja
lgtm
4 years ago (2016-12-02 11:37:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2549493002/1
4 years ago (2016-12-02 12:09:11 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 12:10:53 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-02 12:11:08 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07eca01b73c0f045cf5f54923987c3b91e1d9a7c
Cr-Commit-Position: refs/heads/master@{#41452}

Powered by Google App Engine
This is Rietveld 408576698