Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2549473002: android: Suppress a StrictMode violation coming from the framework. (Closed)

Created:
4 years ago by Benoit L
Modified:
4 years ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Suppress a StrictMode violation coming from the framework. Due to third-party modifications, some devices access the disk in Context#bindService(). This call is supposed to be safe to make from the UI thread, so suppress the StrictMode violation. BUG=670195 Committed: https://crrev.com/66de3a4a8ec8de77b0ee7eed8c86503f22a5eac7 Cr-Commit-Position: refs/heads/master@{#435651}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAServiceClient.java View 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Benoit L
4 years ago (2016-12-01 13:26:01 UTC) #2
Ted C
lgtm
4 years ago (2016-12-01 17:49:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2549473002/1
4 years ago (2016-12-01 18:07:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 18:22:03 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-01 18:24:11 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66de3a4a8ec8de77b0ee7eed8c86503f22a5eac7
Cr-Commit-Position: refs/heads/master@{#435651}

Powered by Google App Engine
This is Rietveld 408576698