Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 2549443005: Fix delayed resolution of function result types (fixes #27760). (Closed)

Created:
4 years ago by regis
Modified:
4 years ago
Reviewers:
hausner, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix delayed resolution of function result types (fixes #27760). Resolution is delayed to properly handle generic results of generic functions. Resolution has to be done in the library declaring the function and not in the library declaring a mixin application mixing in the function. R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/ab6bc6dbfd7bcadfddd6b312926590f6dd832267

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M runtime/vm/parser.cc View 4 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
4 years ago (2016-12-02 22:42:58 UTC) #2
hausner
After some offline discussion, LGTM.
4 years ago (2016-12-02 23:16:23 UTC) #3
regis
4 years ago (2016-12-02 23:22:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ab6bc6dbfd7bcadfddd6b312926590f6dd832267 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698