Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMarqueeElement.idl

Issue 2549443003: Move <marquee> implementation to HTMLMarqueeElement.cpp (Closed)
Patch Set: Add asserts for didParse Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLMarqueeElement.idl
diff --git a/third_party/WebKit/Source/core/html/HTMLMarqueeElement.idl b/third_party/WebKit/Source/core/html/HTMLMarqueeElement.idl
index 410331544198699f9510d9fc838195a5367fa0d7..6a95e651e2b4831d3e4173b79fb5f22510aa407a 100644
--- a/third_party/WebKit/Source/core/html/HTMLMarqueeElement.idl
+++ b/third_party/WebKit/Source/core/html/HTMLMarqueeElement.idl
@@ -20,18 +20,18 @@
// https://html.spec.whatwg.org/#htmlmarqueeelement
interface HTMLMarqueeElement : HTMLElement {
- [ImplementedInPrivateScript, Reflect] attribute DOMString behavior;
- [ImplementedInPrivateScript, Reflect] attribute DOMString bgColor;
- [ImplementedInPrivateScript, Reflect] attribute DOMString direction;
- [ImplementedInPrivateScript, Reflect] attribute DOMString height;
- [ImplementedInPrivateScript, Reflect] attribute unsigned long hspace;
- [ImplementedInPrivateScript] attribute long loop;
+ [Reflect] attribute DOMString behavior;
+ [Reflect] attribute DOMString bgColor;
+ [Reflect] attribute DOMString direction;
+ [Reflect] attribute DOMString height;
+ [Reflect] attribute unsigned long hspace;
+ [RaisesException=Setter] attribute long loop;
// FIXME: scrollAmount and scrollDelay should be unsigned long.
- [ImplementedInPrivateScript] attribute long scrollAmount;
- [ImplementedInPrivateScript] attribute long scrollDelay;
- [ImplementedInPrivateScript, Reflect] attribute boolean trueSpeed;
- [ImplementedInPrivateScript, Reflect] attribute unsigned long vspace;
- [ImplementedInPrivateScript, Reflect] attribute DOMString width;
+ [RaisesException=Setter] attribute long scrollAmount;
+ [RaisesException=Setter] attribute long scrollDelay;
+ [Reflect] attribute boolean trueSpeed;
+ [Reflect] attribute unsigned long vspace;
+ [Reflect] attribute DOMString width;
// FIXME: Implement the following event handler attributes
// https://bugs.webkit.org/show_bug.cgi?id=49788
@@ -39,12 +39,6 @@ interface HTMLMarqueeElement : HTMLElement {
// attribute EventHandler onfinish;
// attribute EventHandler onstart;
- [ImplementedInPrivateScript] void start();
- [ImplementedInPrivateScript] void stop();
-
- // Private script APIs
- [ImplementedInPrivateScript, OnlyExposedToPrivateScript] void createdCallback();
- [ImplementedInPrivateScript, OnlyExposedToPrivateScript] void attachedCallback();
- [ImplementedInPrivateScript, OnlyExposedToPrivateScript] void detachedCallback();
- [ImplementedInPrivateScript, OnlyExposedToPrivateScript] void attributeChangedCallback(DOMString name, DOMString oldValue, DOMString newValue);
+ void start();
+ void stop();
};

Powered by Google App Engine
This is Rietveld 408576698