Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2549423002: Change Enqueuer to use Entity instead of Element. (Closed)

Created:
4 years ago by Johnni Winther
Modified:
4 years ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 4

Patch Set 3 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -137 lines) Patch
M pkg/compiler/lib/src/closure.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/common/backend_api.dart View 1 4 chunks +3 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 13 chunks +32 lines, -47 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 2 15 chunks +25 lines, -26 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/enqueuer.dart View 1 6 chunks +10 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/mirrors_analysis.dart View 5 chunks +7 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 2 chunks +14 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_impact.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/embedded_category_api_boundary_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mirrors_used_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/resolution_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization/model_test_helper.dart View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Johnni Winther
4 years ago (2016-12-06 11:19:59 UTC) #2
Johnni Winther
ping
4 years ago (2016-12-07 10:27:50 UTC) #3
Harry Terkelsen
lgtm https://codereview.chromium.org/2549423002/diff/20001/pkg/compiler/lib/src/js_backend/backend.dart File pkg/compiler/lib/src/js_backend/backend.dart (right): https://codereview.chromium.org/2549423002/diff/20001/pkg/compiler/lib/src/js_backend/backend.dart#newcode526 pkg/compiler/lib/src/js_backend/backend.dart:526: /// `true` if tear-off are supported for incremental ...
4 years ago (2016-12-07 19:03:11 UTC) #4
Johnni Winther
https://codereview.chromium.org/2549423002/diff/20001/pkg/compiler/lib/src/js_backend/backend.dart File pkg/compiler/lib/src/js_backend/backend.dart (right): https://codereview.chromium.org/2549423002/diff/20001/pkg/compiler/lib/src/js_backend/backend.dart#newcode526 pkg/compiler/lib/src/js_backend/backend.dart:526: /// `true` if tear-off are supported for incremental compilation. ...
4 years ago (2016-12-08 08:47:09 UTC) #5
Johnni Winther
4 years ago (2016-12-08 08:51:26 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
53eb4028d8372dab5b300a08b37390601f772521 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698