Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1339)

Unified Diff: cc/trees/layer_tree_host_unittest.cc

Issue 25494009: cc: Fix disabled vsync state freezing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Now with test, and formatted Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/scheduler/scheduler_state_machine.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_unittest.cc
diff --git a/cc/trees/layer_tree_host_unittest.cc b/cc/trees/layer_tree_host_unittest.cc
index 7c5c1a30bed440ce88c1a1796a02716b6cddf464..1624ef0f9041e8108e5457e1230bbe4d8f3d5592 100644
--- a/cc/trees/layer_tree_host_unittest.cc
+++ b/cc/trees/layer_tree_host_unittest.cc
@@ -2399,15 +2399,13 @@ class LayerTreeHostTestBeginFrameNotificationShutdownWhileEnabled
MULTI_THREAD_TEST_F(
LayerTreeHostTestBeginFrameNotificationShutdownWhileEnabled);
-class LayerTreeHostTestAbortedCommitDoesntStallNextCommitWhenIdle
- : public LayerTreeHostTest {
+class LayerTreeHostTestAbortedCommitDoesntStall : public LayerTreeHostTest {
protected:
- LayerTreeHostTestAbortedCommitDoesntStallNextCommitWhenIdle()
+ LayerTreeHostTestAbortedCommitDoesntStall()
: commit_count_(0), commit_complete_count_(0) {}
virtual void InitializeSettings(LayerTreeSettings* settings) OVERRIDE {
settings->begin_frame_scheduling_enabled = true;
- settings->using_synchronous_renderer_compositor = true;
}
virtual void BeginTest() OVERRIDE { PostSetNeedsCommitToMainThread(); }
@@ -2441,8 +2439,26 @@ class LayerTreeHostTestAbortedCommitDoesntStallNextCommitWhenIdle
int commit_complete_count_;
};
+class LayerTreeHostTestAbortedCommitDoesntStallSynchronousCompositor
+ : public LayerTreeHostTestAbortedCommitDoesntStall {
+ virtual void InitializeSettings(LayerTreeSettings* settings) OVERRIDE {
+ LayerTreeHostTestAbortedCommitDoesntStall::InitializeSettings(settings);
+ settings->using_synchronous_renderer_compositor = true;
+ }
+};
+
MULTI_THREAD_TEST_F(
- LayerTreeHostTestAbortedCommitDoesntStallNextCommitWhenIdle);
+ LayerTreeHostTestAbortedCommitDoesntStallSynchronousCompositor);
+
+class LayerTreeHostTestAbortedCommitDoesntStallDisabledVsync
+ : public LayerTreeHostTestAbortedCommitDoesntStall {
+ virtual void InitializeSettings(LayerTreeSettings* settings) OVERRIDE {
+ LayerTreeHostTestAbortedCommitDoesntStall::InitializeSettings(settings);
+ settings->throttle_frame_production = false;
+ }
+};
+
+MULTI_THREAD_TEST_F(LayerTreeHostTestAbortedCommitDoesntStallDisabledVsync);
class LayerTreeHostTestUninvertibleTransformDoesNotBlockActivation
: public LayerTreeHostTest {
« no previous file with comments | « cc/scheduler/scheduler_state_machine.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698