Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25494007: Reland "Hydrogenisation of binops" (Closed)

Created:
7 years, 2 months ago by oliv
Modified:
7 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Reland "Hydrogenisation of binops" BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17104

Patch Set 1 : base #

Patch Set 2 : narrow down the set of pregenerated stubs #

Patch Set 3 : cleanup fpu state after mod call #

Patch Set 4 : fix uint conversion on x64 #

Patch Set 5 : add non-sse2 version of uint32 to double #

Patch Set 6 : remove new boolean recording feature since it regresses some benchmarks #

Patch Set 7 : calm down gc mole #

Patch Set 8 : change output-type selection again and adjust pregen set accordingly #

Total comments: 1

Patch Set 9 : address comments, small fix and normalize output type only for arithmetic ops #

Patch Set 10 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+991 lines, -3777 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +13 lines, -987 lines 0 comments Download
M src/ast.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/code-stubs.h View 1 2 3 4 5 6 7 8 3 chunks +140 lines, -119 lines 0 comments Download
M src/code-stubs.cc View 1 2 3 4 5 6 7 8 2 chunks +453 lines, -95 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 2 3 4 5 6 7 8 1 chunk +96 lines, -0 lines 0 comments Download
M src/hydrogen.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 2 3 4 5 6 7 8 9 5 chunks +94 lines, -98 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 7 chunks +14 lines, -1448 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 3 4 5 6 7 8 9 2 chunks +14 lines, -5 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 3 4 3 chunks +16 lines, -1 line 0 comments Download
M src/ic.h View 1 2 3 4 5 6 7 8 9 3 chunks +6 lines, -13 lines 0 comments Download
M src/ic.cc View 1 2 3 4 5 6 7 8 9 3 chunks +86 lines, -242 lines 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/log.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/objects.h View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -1 line 0 comments Download
M src/spaces.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/type-info.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/type-info.cc View 2 chunks +19 lines, -31 lines 0 comments Download
M src/typing.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/v8-counters.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 4 5 6 7 8 9 6 chunks +13 lines, -728 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
oliv
hei, ptal
7 years, 2 months ago (2013-10-02 14:45:16 UTC) #1
Michael Starzinger
LGTM, rubber-stamped the first patch set and looked at the deltas, one comment to address. ...
7 years, 2 months ago (2013-10-02 16:43:49 UTC) #2
oliv
7 years, 2 months ago (2013-10-04 08:17:26 UTC) #3
Message was sent while issue was closed. 
Committed patchset #9 manually as r17104 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698