Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2549393003: Check client_ isn't null in GpuCompositorframeSink. (Closed)

Created:
4 years ago by kylechar
Modified:
4 years ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, rjkroege, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check client_ isn't null in GpuCompositorframeSink. All other methods that call something on client_ check it's not null first. There is a crash during shutdown for mash_browser_tests that is caused by this. BUG=666481 Committed: https://crrev.com/f244dba45916187f9e025c43bf4d3c49983282d3 Cr-Commit-Position: refs/heads/master@{#436722}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M services/ui/surfaces/gpu_compositor_frame_sink.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
kylechar
4 years ago (2016-12-06 20:09:03 UTC) #2
Fady Samuel
lgtm
4 years ago (2016-12-06 20:10:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2549393003/1
4 years ago (2016-12-06 20:13:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 21:11:59 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-06 21:16:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f244dba45916187f9e025c43bf4d3c49983282d3
Cr-Commit-Position: refs/heads/master@{#436722}

Powered by Google App Engine
This is Rietveld 408576698