Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3242)

Unified Diff: chrome/browser/chromeos/login/wizard_controller.cc

Issue 2549373005: cros: Refactor of BaseScreen::GetName to BaseScreen::screen_id. (Closed)
Patch Set: Nits Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/wizard_controller.cc
diff --git a/chrome/browser/chromeos/login/wizard_controller.cc b/chrome/browser/chromeos/login/wizard_controller.cc
index 3e572c9e2db2e9a3f0245691db37bf9b378c78a6..d5b71add944007d55f10741cbbae2ba8dffd9ea1 100644
--- a/chrome/browser/chromeos/login/wizard_controller.cc
+++ b/chrome/browser/chromeos/login/wizard_controller.cc
@@ -958,8 +958,8 @@ void WizardController::ShowCurrentScreen() {
return;
// First remember how far have we reached so that we can resume if needed.
- if (is_out_of_box_ && IsResumableScreen(current_screen_->GetName()))
- StartupUtils::SaveOobePendingScreen(current_screen_->GetName());
+ if (is_out_of_box_ && IsResumableScreen(current_screen_->screen_id()))
+ StartupUtils::SaveOobePendingScreen(current_screen_->screen_id());
smooth_show_timer_.Stop();
@@ -981,7 +981,7 @@ void WizardController::SetCurrentScreenSmooth(BaseScreen* new_current,
if (current_screen_)
current_screen_->Hide();
- std::string screen_id = new_current->GetName();
+ const std::string screen_id = new_current->screen_id();
if (IsOOBEStepToTrack(screen_id))
screen_show_times_[screen_id] = base::Time::Now();
@@ -1085,7 +1085,7 @@ void WizardController::OnExit(BaseScreen& /* screen */,
ExitCodes exit_code,
const ::login::ScreenContext* /* context */) {
VLOG(1) << "Wizard screen exit code: " << exit_code;
- std::string previous_screen_id = current_screen_->GetName();
+ const std::string previous_screen_id = current_screen_->screen_id();
if (IsOOBEStepToTrack(previous_screen_id)) {
RecordUMAHistogramForOOBEStepCompletionTime(
previous_screen_id,

Powered by Google App Engine
This is Rietveld 408576698