Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: content/browser/frame_host/navigation_request.h

Issue 2549373004: PlzNavigate: Call NavigationHandle::WillProcessResponse for 204/205s (Closed)
Patch Set: Rebase + addressed comments Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/callback_forward.h" 10 #include "base/callback_forward.h"
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 222
223 // These next items are used in browser-initiated navigations to store 223 // These next items are used in browser-initiated navigations to store
224 // information from the NavigationEntryImpl that is required after request 224 // information from the NavigationEntryImpl that is required after request
225 // creation time. 225 // creation time.
226 scoped_refptr<SiteInstanceImpl> source_site_instance_; 226 scoped_refptr<SiteInstanceImpl> source_site_instance_;
227 scoped_refptr<SiteInstanceImpl> dest_site_instance_; 227 scoped_refptr<SiteInstanceImpl> dest_site_instance_;
228 RestoreType restore_type_; 228 RestoreType restore_type_;
229 bool is_view_source_; 229 bool is_view_source_;
230 int bindings_; 230 int bindings_;
231 231
232 // Whether the navigation should be sent to a renderer a process. This is
233 // true, except for 204/205 responses and downloads.
234 bool response_should_be_rendered_;
235
232 // The type of SiteInstance associated with this navigation. 236 // The type of SiteInstance associated with this navigation.
233 AssociatedSiteInstanceType associated_site_instance_type_; 237 AssociatedSiteInstanceType associated_site_instance_type_;
234 238
235 // Whether the request may be transferred to a different process upon commit. 239 // Whether the request may be transferred to a different process upon commit.
236 // True for browser-initiated navigations and renderer-inititated navigations 240 // True for browser-initiated navigations and renderer-inititated navigations
237 // started via the OpenURL path. 241 // started via the OpenURL path.
238 // Note: the RenderFrameHostManager may still decide to have the navigation 242 // Note: the RenderFrameHostManager may still decide to have the navigation
239 // commit in a different renderer process if it detects that a renderer 243 // commit in a different renderer process if it detects that a renderer
240 // transfer is needed. This is the case in particular when --site-per-process 244 // transfer is needed. This is the case in particular when --site-per-process
241 // is enabled. 245 // is enabled.
242 bool may_transfer_; 246 bool may_transfer_;
243 247
244 std::unique_ptr<NavigationHandleImpl> navigation_handle_; 248 std::unique_ptr<NavigationHandleImpl> navigation_handle_;
245 249
246 // Holds the ResourceResponse and the StreamHandle for the navigation while 250 // Holds the ResourceResponse and the StreamHandle for the navigation while
247 // the WillProcessResponse checks are performed by the NavigationHandle. 251 // the WillProcessResponse checks are performed by the NavigationHandle.
248 scoped_refptr<ResourceResponse> response_; 252 scoped_refptr<ResourceResponse> response_;
249 std::unique_ptr<StreamHandle> body_; 253 std::unique_ptr<StreamHandle> body_;
250 254
251 base::Closure on_start_checks_complete_closure_; 255 base::Closure on_start_checks_complete_closure_;
252 256
253 DISALLOW_COPY_AND_ASSIGN(NavigationRequest); 257 DISALLOW_COPY_AND_ASSIGN(NavigationRequest);
254 }; 258 };
255 259
256 } // namespace content 260 } // namespace content
257 261
258 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_H_ 262 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_H_
OLDNEW
« no previous file with comments | « content/browser/frame_host/navigation_handle_impl.cc ('k') | content/browser/frame_host/navigation_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698