Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: content/browser/frame_host/navigation_request.h

Issue 2549373004: PlzNavigate: Call NavigationHandle::WillProcessResponse for 204/205s (Closed)
Patch Set: Fixed test issue Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/callback_forward.h" 10 #include "base/callback_forward.h"
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 219
220 // These next items are used in browser-initiated navigations to store 220 // These next items are used in browser-initiated navigations to store
221 // information from the NavigationEntryImpl that is required after request 221 // information from the NavigationEntryImpl that is required after request
222 // creation time. 222 // creation time.
223 scoped_refptr<SiteInstanceImpl> source_site_instance_; 223 scoped_refptr<SiteInstanceImpl> source_site_instance_;
224 scoped_refptr<SiteInstanceImpl> dest_site_instance_; 224 scoped_refptr<SiteInstanceImpl> dest_site_instance_;
225 RestoreType restore_type_; 225 RestoreType restore_type_;
226 bool is_view_source_; 226 bool is_view_source_;
227 int bindings_; 227 int bindings_;
228 228
229 // Whether the navigation should be sent to a renderer. This is true, except
nasko 2016/12/22 18:16:09 nit: s/renderer/renderer process/
clamy 2016/12/23 16:54:34 Done.
230 // for 204/205 responses and downloads.
231 bool response_should_be_rendered_;
232
229 // The type of SiteInstance associated with this navigation. 233 // The type of SiteInstance associated with this navigation.
230 AssociatedSiteInstanceType associated_site_instance_type_; 234 AssociatedSiteInstanceType associated_site_instance_type_;
231 235
232 std::unique_ptr<NavigationHandleImpl> navigation_handle_; 236 std::unique_ptr<NavigationHandleImpl> navigation_handle_;
233 237
234 // Holds the ResourceResponse and the StreamHandle for the navigation while 238 // Holds the ResourceResponse and the StreamHandle for the navigation while
235 // the WillProcessResponse checks are performed by the NavigationHandle. 239 // the WillProcessResponse checks are performed by the NavigationHandle.
236 scoped_refptr<ResourceResponse> response_; 240 scoped_refptr<ResourceResponse> response_;
237 std::unique_ptr<StreamHandle> body_; 241 std::unique_ptr<StreamHandle> body_;
238 242
239 base::Closure on_start_checks_complete_closure_; 243 base::Closure on_start_checks_complete_closure_;
240 244
241 DISALLOW_COPY_AND_ASSIGN(NavigationRequest); 245 DISALLOW_COPY_AND_ASSIGN(NavigationRequest);
242 }; 246 };
243 247
244 } // namespace content 248 } // namespace content
245 249
246 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_H_ 250 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698