|
|
Created:
4 years ago by sashab Modified:
4 years ago Reviewers:
meade_UTC10 CC:
blink-reviews, chromium-reviews, napper Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionCleaned up make_computed_style_base.py to be better self-documenting
Cleaned up make_computed_style_base.py to have more explicit
dependencies between fields, explain fields and field families, and
generally be better self-documented.
BUG=628043
Committed: https://crrev.com/66e559603ea31d8aad74779fae2e1b6d375833eb
Cr-Commit-Position: refs/heads/master@{#437107}
Patch Set 1 #Patch Set 2 : Removed now unused namedtuple include #
Total comments: 4
Patch Set 3 : Review feedback #Patch Set 4 : Rebase #Messages
Total messages: 18 (7 generated)
sashab@chromium.org changed reviewers: + meade@chromium.org
meade@ ptal :D
lgtm https://codereview.chromium.org/2549373002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/build/scripts/make_computed_style_base.py (right): https://codereview.chromium.org/2549373002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/build/scripts/make_computed_style_base.py:53: assert self.is_enum or self.is_inherited_flag, 'Only one field family can be specified at a time' don't you want assert !(self.is_enum and self.is_inherited_flag), '...' ? otherwise the assert will not be triggered any time self.is_enum is true... https://codereview.chromium.org/2549373002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/build/scripts/make_computed_style_base.py:60: pass I assume there will be something here eventually?
WDYT? see review replies :) https://codereview.chromium.org/2549373002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/build/scripts/make_computed_style_base.py (right): https://codereview.chromium.org/2549373002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/build/scripts/make_computed_style_base.py:53: assert self.is_enum or self.is_inherited_flag, 'Only one field family can be specified at a time' On 2016/12/06 at 03:03:36, Eddy wrote: > don't you want > assert !(self.is_enum and self.is_inherited_flag), '...' > ? > > otherwise the assert will not be triggered any time self.is_enum is true... Oh nice lol :) Whoops https://codereview.chromium.org/2549373002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/build/scripts/make_computed_style_base.py:60: pass On 2016/12/06 at 03:03:36, Eddy wrote: > I assume there will be something here eventually? Yup, think its ok if I leave it there for now just so the branch is there?
Will land after confirming changes are OK :)
On 2016/12/07 03:56:38, sashab wrote: > Will land after confirming changes are OK :) All good, go ahead. FWIW if I LGTM with minor comments, it's ok to land without confirmation :)
:) ty!
The CQ bit was checked by sashab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by sashab@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org Link to the patchset: https://codereview.chromium.org/2549373002/#ps60001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481152184596580, "parent_rev": "f02b011fda652eb44d9551d7156af81a44cbb0ea", "commit_rev": "0760a477a6f57572df850d38649501b48f473b37"}
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Cleaned up make_computed_style_base.py to be better self-documenting Cleaned up make_computed_style_base.py to have more explicit dependencies between fields, explain fields and field families, and generally be better self-documented. BUG=628043 ========== to ========== Cleaned up make_computed_style_base.py to be better self-documenting Cleaned up make_computed_style_base.py to have more explicit dependencies between fields, explain fields and field families, and generally be better self-documented. BUG=628043 Committed: https://crrev.com/66e559603ea31d8aad74779fae2e1b6d375833eb Cr-Commit-Position: refs/heads/master@{#437107} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/66e559603ea31d8aad74779fae2e1b6d375833eb Cr-Commit-Position: refs/heads/master@{#437107} |