Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2549373002: Cleaned up make_computed_style_base.py to be better self-documenting (Closed)

Created:
4 years ago by sashab
Modified:
4 years ago
Reviewers:
meade_UTC10
CC:
blink-reviews, chromium-reviews, napper
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleaned up make_computed_style_base.py to be better self-documenting Cleaned up make_computed_style_base.py to have more explicit dependencies between fields, explain fields and field families, and generally be better self-documented. BUG=628043 Committed: https://crrev.com/66e559603ea31d8aad74779fae2e1b6d375833eb Cr-Commit-Position: refs/heads/master@{#437107}

Patch Set 1 #

Patch Set 2 : Removed now unused namedtuple include #

Total comments: 4

Patch Set 3 : Review feedback #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -33 lines) Patch
M third_party/WebKit/Source/build/scripts/make_computed_style_base.py View 1 2 5 chunks +54 lines, -33 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
sashab
meade@ ptal :D
4 years ago (2016-12-06 02:44:47 UTC) #2
meade_UTC10
lgtm https://codereview.chromium.org/2549373002/diff/20001/third_party/WebKit/Source/build/scripts/make_computed_style_base.py File third_party/WebKit/Source/build/scripts/make_computed_style_base.py (right): https://codereview.chromium.org/2549373002/diff/20001/third_party/WebKit/Source/build/scripts/make_computed_style_base.py#newcode53 third_party/WebKit/Source/build/scripts/make_computed_style_base.py:53: assert self.is_enum or self.is_inherited_flag, 'Only one field family ...
4 years ago (2016-12-06 03:03:36 UTC) #3
sashab
WDYT? see review replies :) https://codereview.chromium.org/2549373002/diff/20001/third_party/WebKit/Source/build/scripts/make_computed_style_base.py File third_party/WebKit/Source/build/scripts/make_computed_style_base.py (right): https://codereview.chromium.org/2549373002/diff/20001/third_party/WebKit/Source/build/scripts/make_computed_style_base.py#newcode53 third_party/WebKit/Source/build/scripts/make_computed_style_base.py:53: assert self.is_enum or self.is_inherited_flag, ...
4 years ago (2016-12-06 03:05:54 UTC) #4
sashab
Will land after confirming changes are OK :)
4 years ago (2016-12-07 03:56:38 UTC) #5
meade_UTC10
On 2016/12/07 03:56:38, sashab wrote: > Will land after confirming changes are OK :) All ...
4 years ago (2016-12-07 04:21:27 UTC) #6
sashab
:) ty!
4 years ago (2016-12-07 06:07:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2549373002/40001
4 years ago (2016-12-07 06:07:22 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/194009)
4 years ago (2016-12-07 07:51:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2549373002/60001
4 years ago (2016-12-07 23:10:19 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-08 01:19:36 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-08 01:22:17 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/66e559603ea31d8aad74779fae2e1b6d375833eb
Cr-Commit-Position: refs/heads/master@{#437107}

Powered by Google App Engine
This is Rietveld 408576698