Multiprocess test client: Android child process launcher rework.

base/process/process.h

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_PROCESS_PROCESS_H_
 #define BASE_PROCESS_PROCESS_H_
 
 #include "base/base_export.h"
 #include "base/macros.h"
 #include "base/process/process_handle.h"
@@ skipping 90 matching lines @@
   // Returns true if the process terminates within the allowed time.
   // NOTE: On POSIX |exit_code| is ignored.
   bool Terminate(int exit_code, bool wait) const;
 
   // Waits for the process to exit. Returns true on success.
   // On POSIX, if the process has been signaled then |exit_code| is set to -1.
   // On Linux this must be a child process, however on Mac and Windows it can be
   // any process.
   // NOTE: |exit_code| is optional, nullptr can be passed if the exit code is
   // not required.
-  bool WaitForExit(int* exit_code);
+  bool WaitForExit(int* exit_code) const;

[Robert Sesek, 2016/12/20 20:44:34]

Is this const-ification related? Seems like it could be done separately.

[Jay Civelli, 2016/12/20 23:07:26]

It is needed as in base/test/multiprocess_test.cc we now call these 2 methods on
a const base::Process&.

 
   // Same as WaitForExit() but only waits for up to |timeout|.
   // NOTE: |exit_code| is optional, nullptr can be passed if the exit code
   // is not required.
-  bool WaitForExitWithTimeout(TimeDelta timeout, int* exit_code);
+  bool WaitForExitWithTimeout(TimeDelta timeout, int* exit_code) const;
 
 #if defined(OS_MACOSX)
   // The Mac needs a Mach port in order to manipulate a process's priority,
   // and there's no good way to get that from base given the pid. These Mac
   // variants of the IsProcessBackgrounded and SetProcessBackgrounded API take
   // a port provider for this reason. See crbug.com/460102
   //
   // A process is backgrounded when its task priority is
   // |TASK_BACKGROUND_APPLICATION|.
   //
@@ skipping 46 matching lines @@
 // Exposed for testing.
 // Given the contents of the /proc/<pid>/cgroup file, determine whether the
 // process is backgrounded or not.
 BASE_EXPORT bool IsProcessBackgroundedCGroup(
     const StringPiece& cgroup_contents);
 #endif  // defined(OS_CHROMEOS)
 
 }  // namespace base
 
 #endif  // BASE_PROCESS_PROCESS_H_