base/test/android/java/src/org/chromium/base/ITestClient.aidl - Issue 2549363004: Multiprocess test client: Android child process launcher rework.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/test/android/java/src/org/chromium/base/ITestClient.aidl

Issue 2549363004: Multiprocess test client: Android child process launcher rework. (Closed)

Patch Set: Sublime ate my channel_pair change... Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« base/test/android/java/src/org/chromium/base/FileDescriptorInfo.java ('K') | « base/test/android/java/src/org/chromium/base/FileDescriptorInfo.java ('k') | base/test/android/java/src/org/chromium/base/MainReturnCodeResult.aidl » ('j') | base/test/android/java/src/org/chromium/base/MainReturnCodeResult.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 package org.chromium.base;

	6

	7 import org.chromium.base.FileDescriptorInfo;

	8 import org.chromium.base.MainReturnCodeResult;

	9

	10 /**

	11 * This interface is used to control child processes.

	12 */

	13 interface ITestClient {

	14 int launch(in String[] args, in FileDescriptorInfo[] fdsToMap);
	nyquist 2016/12/13 20:40:30 Could you explain what the return value is here? I Could you explain what the return value is here? I thought at first it was some error-code, but then it turns out it's the PID. I guess at that point it might look weird not to document the other methods as well. Jay Civelli 2016/12/14 02:20:10 Sorry, I had forgotten to comment that file entire Show quoted text On 2016/12/13 20:40:30, nyquist wrote: > Could you explain what the return value is here? I thought at first it was some > error-code, but then it turns out it's the PID. > > I guess at that point it might look weird not to document the other methods as > well. Sorry, I had forgotten to comment that file entirely. Should be better now.
	15 MainReturnCodeResult waitForMainToReturn(int timeoutMs);

	16 boolean forceStopSynchronous(int exitCode);
	nyquist 2016/12/13 20:40:30 What does the return value signify here? It seems What does the return value signify here? It seems like we're always returning true. Will this change going forward? Jay Civelli 2016/12/14 02:20:10 I explained in the comment. Show quoted text On 2016/12/13 20:40:30, nyquist wrote: > What does the return value signify here? It seems like we're always returning > true. Will this change going forward? I explained in the comment.
	17 void forceStop(int exitCode);

	18 }

OLD	NEW