Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2549353005: Remove ContextLifecycleObserver from MediaStream (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews, tommyw+watchlist_chromium.org, mcasas+watch+mediastream_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ContextLifecycleObserver from MediaStream MediaStream doesn't need to inherit from ContextLifecycleObserver. It just needs to hold a strong member to ExecutionContext. BUG=610176 Committed: https://crrev.com/d4833220d8d9320deb606a0068a332a046486c95 Cr-Commit-Position: refs/heads/master@{#436903}

Patch Set 1 #

Patch Set 2 : temp #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -33 lines) Patch
M third_party/WebKit/Source/modules/mediastream/MediaStream.h View 1 5 chunks +6 lines, -9 lines 3 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.cpp View 1 7 chunks +13 lines, -24 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
haraken
PTAL https://codereview.chromium.org/2549353005/diff/20001/third_party/WebKit/Source/modules/mediastream/MediaStream.h File third_party/WebKit/Source/modules/mediastream/MediaStream.h (right): https://codereview.chromium.org/2549353005/diff/20001/third_party/WebKit/Source/modules/mediastream/MediaStream.h#newcode117 third_party/WebKit/Source/modules/mediastream/MediaStream.h:117: Member<ExecutionContext> m_executionContext; Before this CL, this was a ...
4 years ago (2016-12-07 06:35:01 UTC) #2
sof
lgtm, i like the approach. https://codereview.chromium.org/2549353005/diff/20001/third_party/WebKit/Source/modules/mediastream/MediaStream.h File third_party/WebKit/Source/modules/mediastream/MediaStream.h (right): https://codereview.chromium.org/2549353005/diff/20001/third_party/WebKit/Source/modules/mediastream/MediaStream.h#newcode117 third_party/WebKit/Source/modules/mediastream/MediaStream.h:117: Member<ExecutionContext> m_executionContext; On 2016/12/07 ...
4 years ago (2016-12-07 07:34:16 UTC) #3
haraken
https://codereview.chromium.org/2549353005/diff/20001/third_party/WebKit/Source/modules/mediastream/MediaStream.h File third_party/WebKit/Source/modules/mediastream/MediaStream.h (right): https://codereview.chromium.org/2549353005/diff/20001/third_party/WebKit/Source/modules/mediastream/MediaStream.h#newcode117 third_party/WebKit/Source/modules/mediastream/MediaStream.h:117: Member<ExecutionContext> m_executionContext; On 2016/12/07 07:34:16, sof wrote: > On ...
4 years ago (2016-12-07 08:05:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2549353005/20001
4 years ago (2016-12-07 08:06:06 UTC) #6
sof
On 2016/12/07 08:05:52, haraken wrote: > https://codereview.chromium.org/2549353005/diff/20001/third_party/WebKit/Source/modules/mediastream/MediaStream.h > File third_party/WebKit/Source/modules/mediastream/MediaStream.h (right): > > https://codereview.chromium.org/2549353005/diff/20001/third_party/WebKit/Source/modules/mediastream/MediaStream.h#newcode117 > ...
4 years ago (2016-12-07 08:15:37 UTC) #7
haraken
On 2016/12/07 08:15:37, sof wrote: > On 2016/12/07 08:05:52, haraken wrote: > > > https://codereview.chromium.org/2549353005/diff/20001/third_party/WebKit/Source/modules/mediastream/MediaStream.h ...
4 years ago (2016-12-07 08:17:14 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-07 09:56:45 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-07 09:59:08 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d4833220d8d9320deb606a0068a332a046486c95
Cr-Commit-Position: refs/heads/master@{#436903}

Powered by Google App Engine
This is Rietveld 408576698