third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp - Issue 2549353002: Implement PaintLayer::scrollsWithViewport for SPv2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

Issue 2549353002: Implement PaintLayer::scrollsWithViewport for SPv2. (Closed)

Patch Set: none Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/FrameView.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

index 79777cffaf1d34fb2e44eedef1cd7a4609032a25..1ee5b2d22a5a7dec2d091f2c86020a1f9f2018db 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

@@ -194,7 +194,7 @@ bool CompositingReasonFinder::requiresCompositingForScrollDependentPosition(

// Don't promote fixed position elements that are descendants of a non-view

// container, e.g. transformed elements. They will stay fixed wrt the

// container rather than the enclosing frame.

- if (layer->scrollsWithViewport())

+ if (layer->sticksToViewport())

return m_layoutView.frameView()->isScrollable();

return layer->layoutObject()->style()->position() == StickyPosition &&

layer->ancestorOverflowLayer()->scrollsOverflow();