Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2549353002: Implement PaintLayer::scrollsWithViewport for SPv2. (Closed)
Patch Set: none Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index 653415b131b29c6413086248638b5168ade0a544..03f135fc7446f25369989205fb4250f017bfa301 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -2870,8 +2870,11 @@ void FrameView::updateLifecyclePhasesInternal(
if (targetState >= DocumentLifecycle::PrePaintClean) {
if (!RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled())
invalidateTreeIfNeededRecursive();
- if (view.compositor()->inCompositingMode())
- scrollingCoordinator()->updateAfterCompositingChangeIfNeeded();
+
+ if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
chrishtr 2016/12/06 23:56:07 This code is not needed for SPv2, and tries to cal
+ if (view.compositor()->inCompositingMode())
+ scrollingCoordinator()->updateAfterCompositingChangeIfNeeded();
+ }
updateCompositedSelectionIfNeeded();
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698