third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp - Issue 2549353002: Implement PaintLayer::scrollsWithViewport for SPv2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 2549353002: Implement PaintLayer::scrollsWithViewport for SPv2. (Closed)

Patch Set: none Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/page/AutoscrollController.cpp ('k') | third_party/WebKit/Source/core/paint/ObjectPaintProperties.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

index 6fde443334dd11e05976d3406fb927cb3e945a76..e0d276c1d2c42cf8661c3608c1b50ba38aade4b5 100644

--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

@@ -1114,10 +1114,10 @@ bool ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects(

layoutObject->style()->position() == StickyPosition);

PaintLayer* layer = toLayoutBoxModelObject(layoutObject)->layer();

- // Whether the Layer scrolls with the viewport is a tree-depenent

+ // Whether the Layer sticks to the viewport is a tree-depenent

// property and our viewportConstrainedObjects collection is maintained

// with only LayoutObject-level information.

- if (!layer->scrollsWithViewport())

+ if (!layer->sticksToViewport())

continue;

// If the whole subtree is invisible, there's no reason to scroll on