Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

Issue 2549353002: Implement PaintLayer::scrollsWithViewport for SPv2. (Closed)
Patch Set: none Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/layout/compositing/CompositingReasonFinder.h" 5 #include "core/layout/compositing/CompositingReasonFinder.h"
6 6
7 #include "core/CSSPropertyNames.h" 7 #include "core/CSSPropertyNames.h"
8 #include "core/dom/Document.h" 8 #include "core/dom/Document.h"
9 #include "core/frame/FrameView.h" 9 #include "core/frame/FrameView.h"
10 #include "core/frame/Settings.h" 10 #include "core/frame/Settings.h"
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 if (!(m_compositingTriggers & ViewportConstrainedPositionedTrigger) && 187 if (!(m_compositingTriggers & ViewportConstrainedPositionedTrigger) &&
188 (!RuntimeEnabledFeatures::compositeOpaqueFixedPositionEnabled() || 188 (!RuntimeEnabledFeatures::compositeOpaqueFixedPositionEnabled() ||
189 !layer->backgroundIsKnownToBeOpaqueInRect( 189 !layer->backgroundIsKnownToBeOpaqueInRect(
190 LayoutRect(layer->boundingBoxForCompositing())) || 190 LayoutRect(layer->boundingBoxForCompositing())) ||
191 layer->compositesWithTransform() || layer->compositesWithOpacity())) { 191 layer->compositesWithTransform() || layer->compositesWithOpacity())) {
192 return false; 192 return false;
193 } 193 }
194 // Don't promote fixed position elements that are descendants of a non-view 194 // Don't promote fixed position elements that are descendants of a non-view
195 // container, e.g. transformed elements. They will stay fixed wrt the 195 // container, e.g. transformed elements. They will stay fixed wrt the
196 // container rather than the enclosing frame. 196 // container rather than the enclosing frame.
197 if (layer->scrollsWithViewport()) 197 if (layer->sticksToViewport())
198 return m_layoutView.frameView()->isScrollable(); 198 return m_layoutView.frameView()->isScrollable();
199 return layer->layoutObject()->style()->position() == StickyPosition && 199 return layer->layoutObject()->style()->position() == StickyPosition &&
200 layer->ancestorOverflowLayer()->scrollsOverflow(); 200 layer->ancestorOverflowLayer()->scrollsOverflow();
201 } 201 }
202 202
203 } // namespace blink 203 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | third_party/WebKit/Source/core/page/AutoscrollController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698