Implement PaintLayer::scrollsWithViewport for SPv2.

third_party/WebKit/Source/core/paint/PaintLayerTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/paint/PaintLayer.h"
 
 #include "core/layout/LayoutBoxModelObject.h"
 #include "core/layout/LayoutTestHelper.h"
 #include "core/layout/LayoutView.h"
+#include "platform/testing/RuntimeEnabledFeaturesTestHelpers.h"
 
 namespace blink {
 
-using PaintLayerTest = RenderingTest;
+typedef std::pair<bool, bool> SlimmingPaintAndRootLayerScrolling;
+class PaintLayerTest
+    : public ::testing::WithParamInterface<SlimmingPaintAndRootLayerScrolling>,
+      private ScopedSlimmingPaintV2ForTest,
+      private ScopedRootLayerScrollingForTest,
+      public RenderingTest {
+ public:
+  PaintLayerTest()
+      : ScopedSlimmingPaintV2ForTest(GetParam().first),
+        ScopedRootLayerScrollingForTest(GetParam().second),
+        RenderingTest(SingleChildFrameLoaderClient::create()) {}
+};
 
-TEST_F(PaintLayerTest, CompositedBoundsAbsPosGrandchild) {
+SlimmingPaintAndRootLayerScrolling foo[] = {
+    SlimmingPaintAndRootLayerScrolling(false, false),
+    SlimmingPaintAndRootLayerScrolling(true, false),
+    SlimmingPaintAndRootLayerScrolling(false, true),
+    SlimmingPaintAndRootLayerScrolling(true, true)};
+
+INSTANTIATE_TEST_CASE_P(All, PaintLayerTest, ::testing::ValuesIn(foo));
+
+TEST_P(PaintLayerTest, CompositedBoundsAbsPosGrandchild) {
+  // TODO(chrishtr): fix this test for SPv2
+  if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
+    return;
+
   setBodyInnerHTML(
       " <div id='parent'><div id='absposparent'><div id='absposchild'>"
       " </div></div></div>"
       "<style>"
       "  #parent { position: absolute; z-index: 0; overflow: hidden;"
       "  background: lightgray; width: 150px; height: 150px;"
       "  will-change: transform; }"
       "  #absposparent { position: absolute; z-index: 0; }"
       "  #absposchild { position: absolute; top: 0px; left: 0px; height: 200px;"
       "  width: 200px; background: lightblue; }</style>");
 
   PaintLayer* parentLayer =
       toLayoutBoxModelObject(getLayoutObjectByElementId("parent"))->layer();
   // Since "absposchild" is clipped by "parent", it should not expand the
   // composited bounds for "parent" beyond its intrinsic size of 150x150.
   EXPECT_EQ(LayoutRect(0, 0, 150, 150),
             parentLayer->boundingBoxForCompositing());
 }
 
-TEST_F(PaintLayerTest, PaintingExtentReflection) {
+TEST_P(PaintLayerTest, PaintingExtentReflection) {
   setBodyInnerHTML(
       "<div id='target' style='background-color: blue; position: absolute;"
       "    width: 110px; height: 120px; top: 40px; left: 60px;"
       "    -webkit-box-reflect: below 3px'>"
       "</div>");
 
   PaintLayer* layer =
       toLayoutBoxModelObject(getLayoutObjectByElementId("target"))->layer();
   EXPECT_EQ(
       LayoutRect(60, 40, 110, 243),
       layer->paintingExtent(document().layoutView()->layer(), LayoutSize(), 0));
 }
 
-TEST_F(PaintLayerTest, PaintingExtentReflectionWithTransform) {
+TEST_P(PaintLayerTest, PaintingExtentReflectionWithTransform) {
   setBodyInnerHTML(
       "<div id='target' style='background-color: blue; position: absolute;"
       "    width: 110px; height: 120px; top: 40px; left: 60px;"
       "    -webkit-box-reflect: below 3px; transform: translateX(30px)'>"
       "</div>");
 
   PaintLayer* layer =
       toLayoutBoxModelObject(getLayoutObjectByElementId("target"))->layer();
   EXPECT_EQ(
       LayoutRect(90, 40, 110, 243),
       layer->paintingExtent(document().layoutView()->layer(), LayoutSize(), 0));
 }
 
-TEST_F(PaintLayerTest, CompositedScrollingNoNeedsRepaint) {
+TEST_P(PaintLayerTest, ScrollsWithViewportRelativePosition) {
+  setBodyInnerHTML("<div id='target' style='position: relative'></div>");
+
+  PaintLayer* layer =
+      toLayoutBoxModelObject(getLayoutObjectByElementId("target"))->layer();
+  EXPECT_FALSE(layer->scrollsWithViewport());
+}
+
+TEST_P(PaintLayerTest, ScrollsWithViewportFixedPosition) {
+  setBodyInnerHTML("<div id='target' style='position: fixed'></div>");
+
+  PaintLayer* layer =
+      toLayoutBoxModelObject(getLayoutObjectByElementId("target"))->layer();
+  EXPECT_TRUE(layer->scrollsWithViewport());
+}
+
+TEST_P(PaintLayerTest, ScrollsWithViewportFixedPositionInsideTransform) {
+  setBodyInnerHTML(
+      "<div style='transform: translateZ(0)'>"

[pdr., 2016/12/06 04:38:51]

This isn't correct for spv2 because the viewport doesn't actually scroll. Can
you use the following where the fixed scroller is the transformed element?
"<div style='transform: translateZ(0); height: 10px; overflow: scroll;'>"
"  <div id='target' style='position: fixed;'></div>"
"  <div class='forcescroll' style='height: 5555px;'></div>"
"</div>"
"<div class='forcescroll' style='height: 5555px;'></div>"

Similarly for the other tests, please add "<div class='forcescroll'
style='height: 5555px;'></div>".

[chrishtr, 2016/12/06 23:56:06]

Added here, and also added another test without scrolling.

+      "  <div id='target' style='position: fixed'></div>"
+      "</div>");
+
+  PaintLayer* layer =
+      toLayoutBoxModelObject(getLayoutObjectByElementId("target"))->layer();
+  EXPECT_FALSE(layer->scrollsWithViewport());
+}
+
+TEST_P(PaintLayerTest, ScrollsWithViewportStickyPosition) {
+  setBodyInnerHTML(
+      "<div style='transform: translateZ(0)'>"
+      "  <div id='target' style='position: sticky'></div>"
+      "</div>");
+
+  PaintLayer* layer =
+      toLayoutBoxModelObject(getLayoutObjectByElementId("target"))->layer();
+  EXPECT_TRUE(layer->scrollsWithViewport());
+}
+
+TEST_P(PaintLayerTest, ScrollsWithViewportStickyPositionInsideScroller) {
+  setBodyInnerHTML(
+      "<div style='overflow:scroll; width: 100px; height: 100px;'>"
+      "  <div id='target' style='position: sticky'></div>"
+      "  <div style='width: 50px; height: 1000px;'></div>"
+      "</div>");
+
+  PaintLayer* layer =
+      toLayoutBoxModelObject(getLayoutObjectByElementId("target"))->layer();
+  EXPECT_FALSE(layer->scrollsWithViewport());
+}
+
+TEST_P(PaintLayerTest, CompositedScrollingNoNeedsRepaint) {

[pdr., 2016/12/06 04:38:51]

Nit: Can you file a bug for this and include it here (similarly, for the todo in
CompositedBoundsAbsPosGrandchild)?
// TODO(chrishtr, crbug.com/90210): Despline the spv2 frobinator in the b-tree
hive.

Nit²: CompositedScrollingNoNeedsRepaint -> CompositedScrollingDoesNotNeedRepaint

+  if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
+    return;
+
   enableCompositing();
   setBodyInnerHTML(
       "<div id='scroll' style='width: 100px; height: 100px; overflow: scroll;"
       "    will-change: transform'>"
       "  <div id='content' style='position: relative; background: blue;"
       "      width: 2000px; height: 2000px'></div>"
       "</div>");
 
   PaintLayer* scrollLayer =
       toLayoutBoxModelObject(getLayoutObjectByElementId("scroll"))->layer();
   EXPECT_EQ(PaintsIntoOwnBacking, scrollLayer->compositingState());
 
   PaintLayer* contentLayer =
       toLayoutBoxModelObject(getLayoutObjectByElementId("content"))->layer();
   EXPECT_EQ(NotComposited, contentLayer->compositingState());
   EXPECT_EQ(LayoutPoint(), contentLayer->location());
 
   scrollLayer->getScrollableArea()->setScrollOffset(ScrollOffset(1000, 1000),
                                                     ProgrammaticScroll);
   document().view()->updateAllLifecyclePhasesExceptPaint();
   EXPECT_EQ(LayoutPoint(-1000, -1000), contentLayer->location());
   EXPECT_FALSE(contentLayer->needsRepaint());
   EXPECT_FALSE(scrollLayer->needsRepaint());
   document().view()->updateAllLifecyclePhases();
 }
 
-TEST_F(PaintLayerTest, NonCompositedScrollingNeedsRepaint) {
+TEST_P(PaintLayerTest, NonCompositedScrollingNeedsRepaint) {
   setBodyInnerHTML(
       "<div id='scroll' style='width: 100px; height: 100px; overflow: scroll'>"
       "  <div id='content' style='position: relative; background: blue;"
       "      width: 2000px; height: 2000px'></div>"
       "</div>");
 
   PaintLayer* scrollLayer =
       toLayoutBoxModelObject(getLayoutObjectByElementId("scroll"))->layer();
   EXPECT_EQ(NotComposited, scrollLayer->compositingState());
 
   PaintLayer* contentLayer =
       toLayoutBoxModelObject(getLayoutObjectByElementId("content"))->layer();
   EXPECT_EQ(NotComposited, scrollLayer->compositingState());
   EXPECT_EQ(LayoutPoint(), contentLayer->location());
 
   scrollLayer->getScrollableArea()->setScrollOffset(ScrollOffset(1000, 1000),
                                                     ProgrammaticScroll);
   document().view()->updateAllLifecyclePhasesExceptPaint();
   EXPECT_EQ(LayoutPoint(-1000, -1000), contentLayer->location());
   EXPECT_TRUE(contentLayer->needsRepaint());
   EXPECT_TRUE(scrollLayer->needsRepaint());
   document().view()->updateAllLifecyclePhases();
 }
 
-TEST_F(PaintLayerTest, HasNonIsolatedDescendantWithBlendMode) {
+TEST_P(PaintLayerTest, HasNonIsolatedDescendantWithBlendMode) {
   setBodyInnerHTML(
       "<div id='stacking-grandparent' style='isolation: isolate'>"
       "  <div id='stacking-parent' style='isolation: isolate'>"
       "    <div id='non-stacking-parent' style='position:relative'>"
       "      <div id='blend-mode' style='mix-blend-mode: overlay'>"
       "      </div>"
       "    </div>"
       "  </div>"
       "</div>");
   PaintLayer* stackingGrandparent =
       toLayoutBoxModelObject(getLayoutObjectByElementId("stacking-grandparent"))
           ->layer();
   PaintLayer* stackingParent =
       toLayoutBoxModelObject(getLayoutObjectByElementId("stacking-parent"))
           ->layer();
   PaintLayer* parent =
       toLayoutBoxModelObject(getLayoutObjectByElementId("non-stacking-parent"))
           ->layer();
 
   EXPECT_TRUE(parent->hasNonIsolatedDescendantWithBlendMode());
   EXPECT_TRUE(stackingParent->hasNonIsolatedDescendantWithBlendMode());
   EXPECT_FALSE(stackingGrandparent->hasNonIsolatedDescendantWithBlendMode());
 
   EXPECT_FALSE(parent->hasDescendantWithClipPath());
   EXPECT_TRUE(parent->hasVisibleDescendant());
 }
 
-TEST_F(PaintLayerTest, HasDescendantWithClipPath) {
+TEST_P(PaintLayerTest, HasDescendantWithClipPath) {
   setBodyInnerHTML(
       "<div id='parent' style='position:relative'>"
       "  <div id='clip-path' style='clip-path: circle(50px at 0 100px)'>"
       "  </div>"
       "</div>");
   PaintLayer* parent =
       toLayoutBoxModelObject(getLayoutObjectByElementId("parent"))->layer();
   PaintLayer* clipPath =
       toLayoutBoxModelObject(getLayoutObjectByElementId("clip-path"))->layer();
 
   EXPECT_TRUE(parent->hasDescendantWithClipPath());
   EXPECT_FALSE(clipPath->hasDescendantWithClipPath());
 
   EXPECT_FALSE(parent->hasNonIsolatedDescendantWithBlendMode());
   EXPECT_TRUE(parent->hasVisibleDescendant());
 }
 
-TEST_F(PaintLayerTest, HasVisibleDescendant) {
+TEST_P(PaintLayerTest, HasVisibleDescendant) {
   enableCompositing();
   setBodyInnerHTML(
       "<div id='invisible' style='position:relative'>"
       "  <div id='visible' style='visibility: visible; position: relative'>"
       "  </div>"
       "</div>");
   PaintLayer* invisible =
       toLayoutBoxModelObject(getLayoutObjectByElementId("invisible"))->layer();
   PaintLayer* visible =
       toLayoutBoxModelObject(getLayoutObjectByElementId("visible"))->layer();
 
   EXPECT_TRUE(invisible->hasVisibleDescendant());
   EXPECT_FALSE(visible->hasVisibleDescendant());
 
   EXPECT_FALSE(invisible->hasNonIsolatedDescendantWithBlendMode());
   EXPECT_FALSE(invisible->hasDescendantWithClipPath());
 }
 
 }  // namespace blink