Handle closures, aka FunctionExpression in Kernel!

Handle closures, aka FunctionExpression in Kernel!


BUG=https://github.com/dart-lang/sdk/issues/27394
R=het@google.com, sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/dad37d0386d3b2c840ca7f53a87181617e0b2146

[Emily Fortuna, 2016-12-06 01:31:37]

Patchset #1 (id:1) has been deleted

[Emily Fortuna, 2016-12-06 01:33:11]

efortuna@google.com changed reviewers:
+ sra@google.com

[Emily Fortuna, 2016-12-06 01:33:12]

This causes over 100 additional tests in corelib to pass!
and... more in language. (re-running currently -- tripped up by ninja)

[sra1, 2016-12-06 02:35:41]

lgtm

https://codereview.chromium.org/2549233004/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2549233004/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:462: // FunctionExpressions and
Procedures.
It might be possible to simply use ir.FunctionNode as the type of [target]. That
might have been the intention.

[Harry Terkelsen, 2016-12-06 18:46:36]

het@google.com changed reviewers:
+ het@google.com

[Harry Terkelsen, 2016-12-06 18:46:36]

lgtm

please add some simple tests

https://codereview.chromium.org/2549233004/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2549233004/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:1610:
registry?.registerStaticUse(new StaticUse.foreignUse(callElement));
johnni is making some changes to the registry. I would add him to this CL to see
if this is still correct to do

[Emily Fortuna, 2016-12-06 18:48:29]

> please add some simple tests

Closures are well tested in the language tests. I checked before submitting this
CL. 
 

>
https://codereview.chromium.org/2549233004/diff/20001/pkg/compiler/lib/src/ss...
> File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):
> 
>
https://codereview.chromium.org/2549233004/diff/20001/pkg/compiler/lib/src/ss...
> pkg/compiler/lib/src/ssa/builder_kernel.dart:1610:
> registry?.registerStaticUse(new StaticUse.foreignUse(callElement));
> johnni is making some changes to the registry. I would add him to this CL to
see
> if this is still correct to do

Will do.

[Emily Fortuna, 2016-12-06 18:49:22]

https://codereview.chromium.org/2549233004/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2549233004/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:462: // FunctionExpressions and
Procedures.
On 2016/12/06 02:35:41, sra1 wrote:
> It might be possible to simply use ir.FunctionNode as the type of [target].
That
> might have been the intention.

Done.

https://codereview.chromium.org/2549233004/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:1610:
registry?.registerStaticUse(new StaticUse.foreignUse(callElement));
On 2016/12/06 18:46:36, Harry Terkelsen wrote:
> johnni is making some changes to the registry. I would add him to this CL to
see
> if this is still correct to do

Acknowledged.

[Emily Fortuna, 2016-12-06 18:51:50]

Patchset #2 (id:40001) has been deleted

[Emily Fortuna, 2016-12-06 19:16:35]

Description was changed from

==========
Handle closures, aka FunctionExpression in Kernel!


BUG=https://github.com/dart-lang/sdk/issues/27394
==========

to

==========
Handle closures, aka FunctionExpression in Kernel!


BUG=https://github.com/dart-lang/sdk/issues/27394
R=het@google.com, sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/dad37d0386d3b2c840ca7f53a87181617e0b2146
==========

[Emily Fortuna, 2016-12-06 19:16:36]

Committed patchset #2 (id:60001) manually as
dad37d0386d3b2c840ca7f53a87181617e0b2146 (presubmit successful).