Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: platform_tools/android/bin/android_gdb_exe

Issue 254923003: Improve Android scripts: (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | platform_tools/android/bin/android_gdbserver » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: platform_tools/android/bin/android_gdb_exe
diff --git a/platform_tools/android/bin/android_gdb_exe b/platform_tools/android/bin/android_gdb_exe
index 920a16b38a124abf09da16ac28c332470950b167..bacc20a894c2bb1b6258ae08c2dfa9247a852ac6 100755
--- a/platform_tools/android/bin/android_gdb_exe
+++ b/platform_tools/android/bin/android_gdb_exe
@@ -25,15 +25,18 @@ PORT=5039
# Set up gdb commands
GDBSETUP=$GDB_TMP_DIR/gdb.setup
-echo "file $GDB_TMP_DIR/skia_launcher" >> $GDBSETUP
-echo "target remote :$PORT" >> $GDBSETUP
-echo "set solib-absolute-prefix $GDB_TMP_DIR" >> $GDBSETUP
-echo "set solib-search-path $GDB_TMP_DIR" >> $GDBSETUP
-
-# The apps shared library symbols are not loaded by default so we load them here
-echo "break launch_app" >> $GDBSETUP
-echo "continue" >> $GDBSETUP
-echo "sharedLibrary $APP_NAME" >> $GDBSETUP
+cat > $GDBSETUP <<EOF
+file ${GDB_TMP_DIR}/skia_launcher
+target remote :${PORT}
+set solib-absolute-prefix ${GDB_TMP_DIR}
+set solib-search-path ${GDB_TMP_DIR}
+
+break launch_app
+continue
+sharedLibrary ${APP_NAME}
+EOF
+# The apps shared library symbols are not loaded by default so we load
djsollen 2014/04/29 18:41:14 this comment is not out of place.
hal.canary 2014/04/29 19:08:31 Done.
+# them here.
# Launch gdb client
echo "Entering gdb client shell"
« no previous file with comments | « no previous file | platform_tools/android/bin/android_gdbserver » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698