Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 254923003: Improve Android scripts: (Closed)

Created:
6 years, 7 months ago by hal.canary
Modified:
6 years, 7 months ago
Reviewers:
scroggo, djsollen
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Improve Android scripts: * android_gdbserver: - Don't complain if $GDB_TMP_DIR already exists - Since $GDB_TMP_DIR/gdb.setup might already exist, overwrite the file. * android_run_skia: - Move resource files onto the device. - Change to tmp directory before executing program. * android_make, android_setup: - stop assuming PWD is skia source directory. NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=14442

Patch Set 1 #

Total comments: 2

Patch Set 2 : AnotherPatchSet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -14 lines) Patch
M platform_tools/android/bin/android_gdb_exe View 1 1 chunk +13 lines, -9 lines 0 comments Download
M platform_tools/android/bin/android_gdbserver View 1 chunk +1 line, -1 line 0 comments Download
M platform_tools/android/bin/android_make View 1 chunk +2 lines, -1 line 0 comments Download
M platform_tools/android/bin/android_run_skia View 2 chunks +8 lines, -1 line 0 comments Download
M platform_tools/android/bin/android_setup.sh View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hal.canary
PTAL
6 years, 7 months ago (2014-04-29 16:32:36 UTC) #1
djsollen
lgtm https://codereview.chromium.org/254923003/diff/1/platform_tools/android/bin/android_gdb_exe File platform_tools/android/bin/android_gdb_exe (right): https://codereview.chromium.org/254923003/diff/1/platform_tools/android/bin/android_gdb_exe#newcode38 platform_tools/android/bin/android_gdb_exe:38: # The apps shared library symbols are not ...
6 years, 7 months ago (2014-04-29 18:41:14 UTC) #2
hal.canary
https://codereview.chromium.org/254923003/diff/1/platform_tools/android/bin/android_gdb_exe File platform_tools/android/bin/android_gdb_exe (right): https://codereview.chromium.org/254923003/diff/1/platform_tools/android/bin/android_gdb_exe#newcode38 platform_tools/android/bin/android_gdb_exe:38: # The apps shared library symbols are not loaded ...
6 years, 7 months ago (2014-04-29 19:08:30 UTC) #3
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 7 months ago (2014-04-29 19:09:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/254923003/40001
6 years, 7 months ago (2014-04-29 19:09:50 UTC) #5
commit-bot: I haz the power
Change committed as 14442
6 years, 7 months ago (2014-04-29 19:10:13 UTC) #6
hal.canary
6 years, 7 months ago (2014-04-29 20:59:09 UTC) #7
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/254073003/ by halcanary@google.com.

The reason for reverting is: errors.

Powered by Google App Engine
This is Rietveld 408576698