Chromium Code Reviews
DescriptionReland of placing allocate bitmap IPC messages with a new Mojo interface. (patchset #1 id:1 of https://codereview.chromium.org/2552913003/ )
Reason for revert:
The revert did not help with the crasher, so relanding this CL.
Original issue's description:
> Revert of Replacing allocate bitmap IPC messages with a new Mojo interface. (patchset #13 id:240001 of https://codereview.chromium.org/2488913003/ )
>
> Reason for revert:
> Might be causing a crasher on Windows.
> http://crbug.com/671459
>
> Original issue's description:
> > Replacing the AllocateBitmap related IPC messages with new mojo methods in the
> > RenderMessageFilter interface (it has to be part of the associated interface for
> > now because of ordering issue with other CC messages).
> >
> > As part of that, unified the bitmap allocation behavior in
> > ChildSharedBitmapManager on all platforms, by allocating shared memory
> > with the generic shared memory allocation code path and then
> > registering it as a bitmap.
> > Also moved ChildSharedBitmapManager from the ChildThreadImpl to RenderThreadImpl
> > as it is not common to all child processes.
> >
> > BUG=612500
> > TEST=content_shell should run normally with the --dissable-gpu flag.
> >
> > Committed: https://crrev.com/97235f8be07b5fe9200fe76901d27833325a5996
> > Cr-Commit-Position: refs/heads/master@{#436095}
>
> TBR=rockot@chromium.org,jbauman@chromium.org,kinuko@chromium.org,tsepez@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=612500
>
> Committed: https://crrev.com/9a8e7d0071e6e2492a9f997c22238596ab4122dd
> Cr-Commit-Position: refs/heads/master@{#436629}
TBR=rockot@chromium.org,jbauman@chromium.org,kinuko@chromium.org,tsepez@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=612500
Committed: https://crrev.com/0f21bd5836318170c155a0caf8bc6f81a939213d
Cr-Commit-Position: refs/heads/master@{#437064}
Patch Set 1 #Messages
Total messages: 8 (3 generated)
|