Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2549213002:
Underscore C in "Cast..." in hotdog menu on Windows (Closed)
DescriptionUnderscore C in "Cast..." in hotdog menu on Windows
On Windows, when user opens the hotdog menu with the keyboard shortcut alt-F,
most menu items have underscored characters that will trigger them. Cast can be
triggered by pressing C, and this CL adds an underscore to C in "Cast...".
BUG=667456
Committed: https://crrev.com/8a31bf7b6ee0f53ce944cfaf758b1c37ce6a6ba9
Cr-Commit-Position: refs/heads/master@{#436395}
Patch Set 1 #
Messages
Total messages: 19 (12 generated)
Description was changed from ========== . BUG= ========== to ========== Underscore C in "Cast..." in hotdog menu when opened with the keyboard shortcut on Windows On Windows, when user opens the hotdog menu with alt-F, most menu items have underscored characters that will trigger them. Cast can be triggered by pressing C, and this CL adds an underscore to C in "Cast...". BUG=667456 ==========
Description was changed from ========== Underscore C in "Cast..." in hotdog menu when opened with the keyboard shortcut on Windows On Windows, when user opens the hotdog menu with alt-F, most menu items have underscored characters that will trigger them. Cast can be triggered by pressing C, and this CL adds an underscore to C in "Cast...". BUG=667456 ========== to ========== Underscore C in "Cast..." in hotdog menu on Windows On Windows, when user opens the hotdog menu with the keyboard shortcut alt-F, most menu items have underscored characters that will trigger them. Cast can be triggered by pressing C, and this CL adds an underscore to C in "Cast...". BUG=667456 ==========
Description was changed from ========== Underscore C in "Cast..." in hotdog menu on Windows On Windows, when user opens the hotdog menu with the keyboard shortcut alt-F, most menu items have underscored characters that will trigger them. Cast can be triggered by pressing C, and this CL adds an underscore to C in "Cast...". BUG=667456 ========== to ========== Underscore C in "Cast..." in hotdog menu on Windows On Windows, when user opens the hotdog menu with the keyboard shortcut alt-F, most menu items have underscored characters that will trigger them. Cast can be triggered by pressing C, and this CL adds an underscore to C in "Cast...". BUG=667456 ==========
takumif@chromium.org changed reviewers: + apacible@chromium.org
Please take a look, thanks!
Does this show the underscore the contextual menus as well? If so, is that expected/uniform with the menu in Windows?
On 2016/12/05 19:20:59, apacible wrote: > Does this show the underscore the contextual menus as well? If so, is that > expected/uniform with the menu in Windows? No, the underscore doesn't show for context menus (even if the menu was opened with a keyboard shortcut), and that's consistent with other menu items.
lgtm
The CQ bit was checked by takumif@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by takumif@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480969722912130, "parent_rev":
"104fe9d97d55ebeea29bc45bdbc5e932d9bedfb0", "commit_rev":
"d2e5b00a67944c841a56c2216e37f74fb07f7817"}
Message was sent while issue was closed.
Description was changed from ========== Underscore C in "Cast..." in hotdog menu on Windows On Windows, when user opens the hotdog menu with the keyboard shortcut alt-F, most menu items have underscored characters that will trigger them. Cast can be triggered by pressing C, and this CL adds an underscore to C in "Cast...". BUG=667456 ========== to ========== Underscore C in "Cast..." in hotdog menu on Windows On Windows, when user opens the hotdog menu with the keyboard shortcut alt-F, most menu items have underscored characters that will trigger them. Cast can be triggered by pressing C, and this CL adds an underscore to C in "Cast...". BUG=667456 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Underscore C in "Cast..." in hotdog menu on Windows On Windows, when user opens the hotdog menu with the keyboard shortcut alt-F, most menu items have underscored characters that will trigger them. Cast can be triggered by pressing C, and this CL adds an underscore to C in "Cast...". BUG=667456 ========== to ========== Underscore C in "Cast..." in hotdog menu on Windows On Windows, when user opens the hotdog menu with the keyboard shortcut alt-F, most menu items have underscored characters that will trigger them. Cast can be triggered by pressing C, and this CL adds an underscore to C in "Cast...". BUG=667456 Committed: https://crrev.com/8a31bf7b6ee0f53ce944cfaf758b1c37ce6a6ba9 Cr-Commit-Position: refs/heads/master@{#436395} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8a31bf7b6ee0f53ce944cfaf758b1c37ce6a6ba9 Cr-Commit-Position: refs/heads/master@{#436395} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
