Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: base/time/time_unittest.cc

Issue 2549203002: Add a space before seconds units like all other units. (Closed)
Patch Set: Updated doc. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/time/time.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/time/time.h" 5 #include "base/time/time.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 #include <time.h> 8 #include <time.h>
9 #include <limits> 9 #include <limits>
10 #include <string> 10 #include <string>
(...skipping 1098 matching lines...) Expand 10 before | Expand all | Expand 10 after
1109 EXPECT_EQ(-one_second, (ticks_now - one_second) - ticks_now); 1109 EXPECT_EQ(-one_second, (ticks_now - one_second) - ticks_now);
1110 EXPECT_EQ(one_second, (ticks_now + one_second) - ticks_now); 1110 EXPECT_EQ(one_second, (ticks_now + one_second) - ticks_now);
1111 } 1111 }
1112 1112
1113 TEST(TimeDeltaLogging, DCheckEqCompiles) { 1113 TEST(TimeDeltaLogging, DCheckEqCompiles) {
1114 DCHECK_EQ(TimeDelta(), TimeDelta()); 1114 DCHECK_EQ(TimeDelta(), TimeDelta());
1115 } 1115 }
1116 1116
1117 TEST(TimeDeltaLogging, EmptyIsZero) { 1117 TEST(TimeDeltaLogging, EmptyIsZero) {
1118 TimeDelta zero; 1118 TimeDelta zero;
1119 EXPECT_EQ("0s", AnyToString(zero)); 1119 EXPECT_EQ("0 s", AnyToString(zero));
1120 } 1120 }
1121 1121
1122 TEST(TimeDeltaLogging, FiveHundredMs) { 1122 TEST(TimeDeltaLogging, FiveHundredMs) {
1123 TimeDelta five_hundred_ms = TimeDelta::FromMilliseconds(500); 1123 TimeDelta five_hundred_ms = TimeDelta::FromMilliseconds(500);
1124 EXPECT_EQ("0.5s", AnyToString(five_hundred_ms)); 1124 EXPECT_EQ("0.5 s", AnyToString(five_hundred_ms));
1125 } 1125 }
1126 1126
1127 TEST(TimeDeltaLogging, MinusTenSeconds) { 1127 TEST(TimeDeltaLogging, MinusTenSeconds) {
1128 TimeDelta minus_ten_seconds = TimeDelta::FromSeconds(-10); 1128 TimeDelta minus_ten_seconds = TimeDelta::FromSeconds(-10);
1129 EXPECT_EQ("-10s", AnyToString(minus_ten_seconds)); 1129 EXPECT_EQ("-10 s", AnyToString(minus_ten_seconds));
1130 } 1130 }
1131 1131
1132 TEST(TimeDeltaLogging, DoesNotMessUpFormattingFlags) { 1132 TEST(TimeDeltaLogging, DoesNotMessUpFormattingFlags) {
1133 std::ostringstream oss; 1133 std::ostringstream oss;
1134 std::ios_base::fmtflags flags_before = oss.flags(); 1134 std::ios_base::fmtflags flags_before = oss.flags();
1135 oss << TimeDelta(); 1135 oss << TimeDelta();
1136 EXPECT_EQ(flags_before, oss.flags()); 1136 EXPECT_EQ(flags_before, oss.flags());
1137 } 1137 }
1138 1138
1139 TEST(TimeDeltaLogging, DoesNotMakeStreamBad) { 1139 TEST(TimeDeltaLogging, DoesNotMakeStreamBad) {
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
1190 1190
1191 TEST(TimeTicksLogging, DoesNotMakeStreamBad) { 1191 TEST(TimeTicksLogging, DoesNotMakeStreamBad) {
1192 std::ostringstream oss; 1192 std::ostringstream oss;
1193 oss << TimeTicks(); 1193 oss << TimeTicks();
1194 EXPECT_TRUE(oss.good()); 1194 EXPECT_TRUE(oss.good());
1195 } 1195 }
1196 1196
1197 } // namespace 1197 } // namespace
1198 1198
1199 } // namespace base 1199 } // namespace base
OLDNEW
« no previous file with comments | « base/time/time.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698