Issue 25492006: Makes the response to CheckNotificationPermission asynchronous.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25492006: Makes the response to CheckNotificationPermission asynchronous. (Closed)

Created:
7 years, 2 months ago by dewittj

Modified:
7 years, 1 month ago

Reviewers:

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Makes the response to CheckNotificationPermission asynchronous. Some data that's required to make a decision about notification permissions is only available on the UI thread. The message requesting the permission status is synchronous, which implies that it will arrive on the IO thread. To get data on the appropriate thread (and stop a crash in the wild), post task over to the UI thread to get the correct data and return the response when available. BUG=256638

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -79 lines)			Patch
M	chrome/browser/chrome_content_browser_client.cc	View	1	1 chunk	+13 lines, -26 lines	0 comments	Download
M	chrome/browser/notifications/desktop_notification_service.h	View		3 chunks	+8 lines, -2 lines	0 comments	Download
M	chrome/browser/notifications/desktop_notification_service.cc	View		4 chunks	+45 lines, -3 lines	0 comments	Download
M	chrome/browser/profiles/profile_io_data.h	View		4 chunks	+0 lines, -13 lines	0 comments	Download
M	chrome/browser/profiles/profile_io_data.cc	View		6 chunks	+1 line, -26 lines	0 comments	Download
M	content/browser/renderer_host/render_message_filter.h	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_message_filter.cc	View	1	3 chunks	+36 lines, -7 lines	0 comments	Download
M	content/public/browser/content_browser_client.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download