Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp

Issue 2549143009: Create PendingScriptClient as a separate client interface for PendingScript. (Closed)
Patch Set: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp
index 31b569854020a6170bd15e6e55e09323245bc5b1..f99a1d1ba0c60e790b2cb60a8a46d504ddc9dda7 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp
@@ -91,17 +91,14 @@ class ScriptStreamingTest : public ::testing::Test {
Persistent<PendingScript> m_pendingScript;
};
-class TestScriptResourceClient
- : public GarbageCollectedFinalized<TestScriptResourceClient>,
- public ScriptResourceClient {
- USING_GARBAGE_COLLECTED_MIXIN(TestScriptResourceClient);
+class TestPendingScriptClient
+ : public GarbageCollectedFinalized<TestPendingScriptClient>,
+ public PendingScriptClient {
+ USING_GARBAGE_COLLECTED_MIXIN(TestPendingScriptClient);
public:
- TestScriptResourceClient() : m_finished(false) {}
-
- void notifyFinished(Resource*) override { m_finished = true; }
- String debugName() const override { return "TestScriptResourceClient"; }
-
+ TestPendingScriptClient() : m_finished(false) {}
+ void pendingScriptFinished(PendingScript*) override { m_finished = true; }
bool finished() const { return m_finished; }
private:
@@ -114,7 +111,7 @@ TEST_F(ScriptStreamingTest, CompilingStreamedScript) {
ScriptStreamer::startStreaming(
getPendingScript(), ScriptStreamer::ParsingBlocking, m_settings.get(),
scope.getScriptState(), m_loadingTaskRunner);
- TestScriptResourceClient* client = new TestScriptResourceClient;
+ TestPendingScriptClient* client = new TestPendingScriptClient;
getPendingScript()->watchForLoad(client);
appendData("function foo() {");
@@ -149,7 +146,7 @@ TEST_F(ScriptStreamingTest, CompilingStreamedScriptWithParseError) {
ScriptStreamer::startStreaming(
getPendingScript(), ScriptStreamer::ParsingBlocking, m_settings.get(),
scope.getScriptState(), m_loadingTaskRunner);
- TestScriptResourceClient* client = new TestScriptResourceClient;
+ TestPendingScriptClient* client = new TestPendingScriptClient;
getPendingScript()->watchForLoad(client);
appendData("function foo() {");
appendData("this is the part which will be a parse error");
@@ -185,7 +182,7 @@ TEST_F(ScriptStreamingTest, CancellingStreaming) {
ScriptStreamer::startStreaming(
getPendingScript(), ScriptStreamer::ParsingBlocking, m_settings.get(),
scope.getScriptState(), m_loadingTaskRunner);
- TestScriptResourceClient* client = new TestScriptResourceClient;
+ TestPendingScriptClient* client = new TestPendingScriptClient;
getPendingScript()->watchForLoad(client);
appendData("function foo() {");
@@ -215,7 +212,7 @@ TEST_F(ScriptStreamingTest, SuppressingStreaming) {
ScriptStreamer::startStreaming(
getPendingScript(), ScriptStreamer::ParsingBlocking, m_settings.get(),
scope.getScriptState(), m_loadingTaskRunner);
- TestScriptResourceClient* client = new TestScriptResourceClient;
+ TestPendingScriptClient* client = new TestPendingScriptClient;
getPendingScript()->watchForLoad(client);
appendData("function foo() {");
appendPadding();
@@ -248,7 +245,7 @@ TEST_F(ScriptStreamingTest, EmptyScripts) {
ScriptStreamer::startStreaming(
getPendingScript(), ScriptStreamer::ParsingBlocking, m_settings.get(),
scope.getScriptState(), m_loadingTaskRunner);
- TestScriptResourceClient* client = new TestScriptResourceClient;
+ TestPendingScriptClient* client = new TestPendingScriptClient;
getPendingScript()->watchForLoad(client);
// Finish the script without sending any data.
@@ -272,7 +269,7 @@ TEST_F(ScriptStreamingTest, SmallScripts) {
ScriptStreamer::startStreaming(
getPendingScript(), ScriptStreamer::ParsingBlocking, m_settings.get(),
scope.getScriptState(), m_loadingTaskRunner);
- TestScriptResourceClient* client = new TestScriptResourceClient;
+ TestPendingScriptClient* client = new TestPendingScriptClient;
getPendingScript()->watchForLoad(client);
appendData("function foo() { }");
@@ -299,7 +296,7 @@ TEST_F(ScriptStreamingTest, ScriptsWithSmallFirstChunk) {
ScriptStreamer::startStreaming(
getPendingScript(), ScriptStreamer::ParsingBlocking, m_settings.get(),
scope.getScriptState(), m_loadingTaskRunner);
- TestScriptResourceClient* client = new TestScriptResourceClient;
+ TestPendingScriptClient* client = new TestPendingScriptClient;
getPendingScript()->watchForLoad(client);
// This is the first data chunk which is small.
@@ -333,7 +330,7 @@ TEST_F(ScriptStreamingTest, EncodingChanges) {
ScriptStreamer::startStreaming(
getPendingScript(), ScriptStreamer::ParsingBlocking, m_settings.get(),
scope.getScriptState(), m_loadingTaskRunner);
- TestScriptResourceClient* client = new TestScriptResourceClient;
+ TestPendingScriptClient* client = new TestPendingScriptClient;
getPendingScript()->watchForLoad(client);
m_resource->setEncoding("UTF-8");
@@ -368,7 +365,7 @@ TEST_F(ScriptStreamingTest, EncodingFromBOM) {
ScriptStreamer::startStreaming(
getPendingScript(), ScriptStreamer::ParsingBlocking, m_settings.get(),
scope.getScriptState(), m_loadingTaskRunner);
- TestScriptResourceClient* client = new TestScriptResourceClient;
+ TestPendingScriptClient* client = new TestPendingScriptClient;
getPendingScript()->watchForLoad(client);
// \xef\xbb\xbf is the UTF-8 byte order mark. \xec\x92\x81 are the raw bytes

Powered by Google App Engine
This is Rietveld 408576698