Implement 'Import Library' Quick Fix for the new analysis driver.

Implement 'Import Library' Quick Fix for the new analysis driver.

It turned out to be easier than I thought is would be.

The potential problem was to find correspondence between AnalysisResult
and the AnalysisDriver instance to request top-level declarations in.
But if we just include the AnalysisDriver into AnalysisResult, this
solves the problem.

This creates another problem though - now we need to be careful to
not cache an instance of AnalysisResult for a long time.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/402cd0b6466e056386c44e3cd2f607d29f2db370

[Brian Wilkerson, 2016-12-06 22:58:27]

lgtm

[scheglov, 2016-12-06 23:00:59]

Description was changed from

==========
Implement 'Import Library' Quick Fix for the new analysis driver.

It turned out to be easier than I thought is would be.

The potential problem was to find correspondence between AnalysisResult
and the AnalysisDriver instance to request top-level declarations in.
But if we just include the AnalysisDriver into AnalysisResult, this
solves the problem.

This creates another problem though - now we need to be careful to
not cache an instance of AnalysisResult for a long time.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Implement 'Import Library' Quick Fix for the new analysis driver.

It turned out to be easier than I thought is would be.

The potential problem was to find correspondence between AnalysisResult
and the AnalysisDriver instance to request top-level declarations in.
But if we just include the AnalysisDriver into AnalysisResult, this
solves the problem.

This creates another problem though - now we need to be careful to
not cache an instance of AnalysisResult for a long time.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/402cd0b6466e056386c44e3cd2f607d29f2db370
==========

[scheglov, 2016-12-06 23:01:00]

Committed patchset #1 (id:1) manually as
402cd0b6466e056386c44e3cd2f607d29f2db370 (presubmit successful).

[Paul Berry, 2016-12-07 14:57:34]

I agree that including the AnalysisDriver inside the AnalysisResult seems
bad--it's a potential trap for clients.  What if instead we allow the client to
suppy an "AnalysisDriver key" (which can be any object) when they create the
AnalysisDriver, and then we include that key in the AnalysisResult?

Then analysis server could use this "key" to associate a unique ID with every
AnalysisDriver, and when it needs to map an AnalysisResult to an AnalysisDriver,
it can just look it up in a map?