Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: tools/perf/benchmarks/oortonline.py

Issue 2549143005: Disable oortonline_tbmv2 on Nexus 9 due to repeated failures (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import re 5 import re
6 6
7 import page_sets 7 import page_sets
8 8
9 from core import perf_benchmark 9 from core import perf_benchmark
10 from telemetry import benchmark 10 from telemetry import benchmark
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 ','.join(categories)) 88 ','.join(categories))
89 options = timeline_based_measurement.Options(category_filter) 89 options = timeline_based_measurement.Options(category_filter)
90 options.SetTimelineBasedMetrics([ 90 options.SetTimelineBasedMetrics([
91 'gcMetric', 'memoryMetric', 'responsivenessMetric']) 91 'gcMetric', 'memoryMetric', 'responsivenessMetric'])
92 # Setting an empty memory dump config disables periodic dumps. 92 # Setting an empty memory dump config disables periodic dumps.
93 options.config.chrome_trace_config.SetMemoryDumpConfig( 93 options.config.chrome_trace_config.SetMemoryDumpConfig(
94 chrome_trace_config.MemoryDumpConfig()) 94 chrome_trace_config.MemoryDumpConfig())
95 return options 95 return options
96 96
97 @classmethod 97 @classmethod
98 def ShouldDisable(cls, possible_browser):
99 return possible_browser.platform.GetDeviceTypeName() == 'Nexus 9'
100
101 @classmethod
98 def Name(cls): 102 def Name(cls):
99 return 'oortonline_tbmv2' 103 return 'oortonline_tbmv2'
100 104
101 @classmethod 105 @classmethod
102 def ValueCanBeAddedPredicate(cls, value, _): 106 def ValueCanBeAddedPredicate(cls, value, _):
103 if 'memory:chrome' in value.name: 107 if 'memory:chrome' in value.name:
104 return bool(cls._V8_AND_OVERALL_MEMORY_RE.search(value.name)) 108 return bool(cls._V8_AND_OVERALL_MEMORY_RE.search(value.name))
105 if 'animation ' in value.name: 109 if 'animation ' in value.name:
106 return 'throughput' in value.name or 'frameTimeDiscrepancy' in value.name 110 return 'throughput' in value.name or 'frameTimeDiscrepancy' in value.name
107 return 'v8' in value.name 111 return 'v8' in value.name
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698