Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: net/http/http_response_headers.h

Issue 2549143003: Cleaned up the API of HttpUtil::ParseContentRangeHeader(). (Closed)
Patch Set: Fixed unittest Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_cache_unittest.cc ('k') | net/http/http_response_headers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_response_headers.h
diff --git a/net/http/http_response_headers.h b/net/http/http_response_headers.h
index 39404cfd9f2f444bb281a67db454651107b4e770..6dc14a9ac828d9f820d4db8adf514b2be90862ad 100644
--- a/net/http/http_response_headers.h
+++ b/net/http/http_response_headers.h
@@ -292,16 +292,16 @@ class NET_EXPORT HttpResponseHeaders
// such header in the response.
int64_t GetInt64HeaderValue(const std::string& header) const;
- // Extracts the values in a Content-Range header and returns true if they are
- // valid for a 206 response; otherwise returns false.
+ // Extracts the values in a Content-Range header and returns true if all three
+ // values are present and valid for a 206 response; otherwise returns false.
// The following values will be outputted:
// |*first_byte_position| = inclusive position of the first byte of the range
// |*last_byte_position| = inclusive position of the last byte of the range
// |*instance_length| = size in bytes of the object requested
- // If any of the above values is unknown, its value will be -1.
- bool GetContentRange(int64_t* first_byte_position,
- int64_t* last_byte_position,
- int64_t* instance_length) const;
+ // If this method returns false, then all of the outputs will be -1.
+ bool GetContentRangeFor206(int64_t* first_byte_position,
+ int64_t* last_byte_position,
+ int64_t* instance_length) const;
// Returns true if the response is chunk-encoded.
bool IsChunkEncoded() const;
« no previous file with comments | « net/http/http_cache_unittest.cc ('k') | net/http/http_response_headers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698