content/renderer/media/crypto/key_systems.cc - Issue 254913002: KeySystems: IsSupportedContainerAndCodecs() ignores empty codec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/crypto/key_systems.cc

Issue 254913002: KeySystems: IsSupportedContainerAndCodecs() ignores empty codec. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/crypto/key_systems.cc

diff --git a/content/renderer/media/crypto/key_systems.cc b/content/renderer/media/crypto/key_systems.cc

index 75a13a65eefd9c9b19b047c571b08831a898ac3f..724b829ca0a90514dc1f2314328f64d75c094ab4 100644

--- a/content/renderer/media/crypto/key_systems.cc

+++ b/content/renderer/media/crypto/key_systems.cc

@@ -281,7 +281,8 @@ bool KeySystems::IsSupportedContainerAndCodecs(

for (size_t i = 0; i < codecs.size(); ++i) {

const std::string& codec = codecs[i];

- DCHECK(!codec.empty());

+ if (codec.empty())

ddorwin 2014/04/26 00:51:36 Does this cause use to accept a real string like "

+ continue;

CodecMaskMap::const_iterator codec_iter = codec_masks_.find(codec);

if (codec_iter == codec_masks_.end()) // Unrecognized codec.

return false;

« no previous file with comments | « no previous file | no next file » | no next file with comments »