KeySystems: IsSupportedContainerAndCodecs() ignores empty codec.

KeySystems: IsSupportedContainerAndCodecs() ignores empty codec.

In IsTypeSupported() call, when the codec string in the mime type contains extra
commas, e.g. ",vorbis", an empty codec will be passed into
IsSupportedContainerAndCodecs. In this case, we should ignore that codec instead
of assuming it's not empty.

BUG=362769
TEST=Layout test crash is fixed.

[xhwang, 2014-04-26 00:50:48]

PTAL

[ddorwin, 2014-04-26 00:51:36]

LGTM with comment.

https://codereview.chromium.org/254913002/diff/1/content/renderer/media/crypt...
File content/renderer/media/crypto/key_systems.cc (right):

https://codereview.chromium.org/254913002/diff/1/content/renderer/media/crypt...
content/renderer/media/crypto/key_systems.cc:284: if (codec.empty())
Does this cause use to accept a real string like "foo, , bar" or "foo,"? I
wonder whether we should.

Does canPlayType()?

[xhwang, 2014-04-26 00:58:40]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2014-04-26 01:00:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xhwang@chromium.org/254913002/1

[commit-bot: I haz the power, 2014-04-26 03:14:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-26 03:14:16]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[xhwang, 2014-04-26 03:46:43]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2014-04-26 03:47:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xhwang@chromium.org/254913002/1

[Dan Beam, 2014-04-26 03:58:16]

this CL seems to have landed on a closed tree without mentioning it on the
review... is such a thing even possible? YES IT IS (apparently)

[commit-bot: I haz the power, 2014-04-26 04:17:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-26 04:17:15]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[xhwang, 2014-04-28 18:20:58]

On 2014/04/26 03:58:16, Dan Beam wrote:
> this CL seems to have landed on a closed tree without mentioning it on the
> review... is such a thing even possible? YES IT IS (apparently)

For the record. I dcommited this CL when the tree is closed to fix a lot of
failing layout tests:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40...

Yes, it also surprised that there's no record on this code review. Maybe I
shouldn't have done this in the first place :(

I'll close this issue manually.

[xhwang, 2014-04-28 18:24:30]

This was committed as r266335.

[Dan Beam, 2014-04-28 18:25:34]

but even if you dcommitted it probably should've closed the issue and say
"committed as rXXX" (like you just added manually).  maybe you accidentally
typed "git svn dcommit" rather than "git cl dcommit"?

[xhwang, 2014-04-28 18:30:04]

On 2014/04/28 18:25:34, Dan Beam wrote:
> but even if you dcommitted it probably should've closed the issue and say
> "committed as rXXX" (like you just added manually).  maybe you accidentally
> typed "git svn dcommit" rather than "git cl dcommit"?

No. I am pretty sure I typed "git cl dcommit --bypass-hooks".