Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2549113002: [turbofan] Remove obsolete eval call bailout ids. (Closed)

Created:
4 years ago by Michael Starzinger
Modified:
4 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove obsolete eval call bailout ids. Calls that are potential eval calls are funneled through bytecode and hence no longer use the {AstGraphBuilder} by now. Associated bailout points can be removed. R=jarin@chromium.org Committed: https://crrev.com/84ea200ad8db90f9cdf12dc82963110cc15f5d82 Cr-Commit-Position: refs/heads/master@{#41489}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -33 lines) Patch
M src/ast/ast.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -29 lines 1 comment Download

Messages

Total messages: 12 (7 generated)
Michael Starzinger
https://codereview.chromium.org/2549113002/diff/1/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right): https://codereview.chromium.org/2549113002/diff/1/src/compiler/ast-graph-builder.cc#newcode1743 src/compiler/ast-graph-builder.cc:1743: CHECK(!expr->is_possibly_eval()); remark: Assertion already present here.
4 years ago (2016-12-05 13:13:33 UTC) #1
Jarin
lgtm. Thanks!
4 years ago (2016-12-05 13:17:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2549113002/1
4 years ago (2016-12-05 13:46:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 13:48:48 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-05 13:48:57 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84ea200ad8db90f9cdf12dc82963110cc15f5d82
Cr-Commit-Position: refs/heads/master@{#41489}

Powered by Google App Engine
This is Rietveld 408576698