Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: third_party/WebKit/Source/platform/audio/AudioDestination.h

Issue 2549093009: Introduce PushPullFIFO class and remove other FIFOs (Closed)
Patch Set: Remove old FIFO classes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/audio/AudioDestination.h
diff --git a/third_party/WebKit/Source/platform/audio/AudioDestination.h b/third_party/WebKit/Source/platform/audio/AudioDestination.h
index d0e35b80c7802e71e809db860a1a609cd40741cc..e4a161b1ebfbba917f91564eb247655c6fd306dd 100644
--- a/third_party/WebKit/Source/platform/audio/AudioDestination.h
+++ b/third_party/WebKit/Source/platform/audio/AudioDestination.h
@@ -31,7 +31,6 @@
#include "platform/audio/AudioBus.h"
#include "platform/audio/AudioIOCallback.h"
-#include "platform/audio/AudioSourceProvider.h"
#include "public/platform/WebAudioDevice.h"
#include "public/platform/WebVector.h"
#include "wtf/Allocator.h"
@@ -41,15 +40,14 @@
namespace blink {
-class AudioPullFIFO;
+class PushPullFIFO;
class SecurityOrigin;
// The AudioDestination class is an audio sink interface between the media
// renderer and the Blink's WebAudio module. It has a FIFO to adapt the
// different processing block sizes of WebAudio renderer and actual hardware
// audio callback.
-class PLATFORM_EXPORT AudioDestination : public WebAudioDevice::RenderCallback,
- public AudioSourceProvider {
+class PLATFORM_EXPORT AudioDestination : public WebAudioDevice::RenderCallback {
USING_FAST_MALLOC(AudioDestination);
WTF_MAKE_NONCOPYABLE(AudioDestination);
@@ -74,9 +72,6 @@ class PLATFORM_EXPORT AudioDestination : public WebAudioDevice::RenderCallback,
double delayTimestamp,
size_t priorFramesSkipped) override;
- // AudioSourceProvider (FIFO)
- void provideInput(AudioBus* outputBus, size_t framesToProcess) override;
-
virtual void start();
virtual void stop();
@@ -99,7 +94,8 @@ class PLATFORM_EXPORT AudioDestination : public WebAudioDevice::RenderCallback,
AudioIOCallback& m_callback;
RefPtr<AudioBus> m_outputBus;
- std::unique_ptr<AudioPullFIFO> m_fifo;
+ RefPtr<AudioBus> m_renderBus;
+ std::unique_ptr<PushPullFIFO> m_fifo;
Raymond Toy 2017/01/06 22:22:03 Please add comments on what m_renderBus and m_fifo
hongchan 2017/01/09 21:53:15 Done.
size_t m_framesElapsed;
AudioIOPosition m_outputPosition;

Powered by Google App Engine
This is Rietveld 408576698