[counters] Move waiting for more data from background-parsing into callbacks

[counters] Move waiting for more data from background-parsing into callbacks

BUG=

Committed: https://crrev.com/ce63eb08f9da8036693ec8f5198853033834f7d5
Cr-Commit-Position: refs/heads/master@{#41492}

[Toon Verwaest, 2016-12-05 12:27:11]

verwaest@chromium.org changed reviewers:
+ cbruni@chromium.org, vogelheim@chromium.org

[Toon Verwaest, 2016-12-05 12:27:12]

ptal

[Camillo Bruni, 2016-12-05 12:33:19]

LGTM with nit

https://codereview.chromium.org/2549083002/diff/1/src/parsing/scanner-charact...
File src/parsing/scanner-character-streams.cc (right):

https://codereview.chromium.org/2549083002/diff/1/src/parsing/scanner-charact...
src/parsing/scanner-character-streams.cc:648: // woByteExternalBufferedStream
Spurious change.

[vogelheim, 2016-12-05 12:35:29]

lgtm.

Some nitpicks, though. :)

https://codereview.chromium.org/2549083002/diff/1/src/counters.h
File src/counters.h (right):

https://codereview.chromium.org/2549083002/diff/1/src/counters.h#newcode696
src/counters.h:696: V(GetMoreDataCallback)                            \
Nitpick: Usually c < e, but I'm not sure if we're sorting case-insensitive here.

https://codereview.chromium.org/2549083002/diff/1/src/parsing/scanner-charact...
File src/parsing/scanner-character-streams.cc (right):

https://codereview.chromium.org/2549083002/diff/1/src/parsing/scanner-charact...
src/parsing/scanner-character-streams.cc:337: RuntimeCallTimerScope
scope(stats_, &RuntimeCallStats::GetMoreDataCallback);
Why does this compile without a new #include? I guess counters.h is included
somewhere from the include/v8.h or objects.h mega-headers?

Maybe in include-what-you-need fashion we should include this directly, in case
of later #include-cleanups?

https://codereview.chromium.org/2549083002/diff/1/src/parsing/scanner-charact...
src/parsing/scanner-character-streams.cc:648: // woByteExternalBufferedStream
Huh? (Editing error, I guess?)

[vogelheim, 2016-12-05 12:35:29]

lgtm.

Some nitpicks, though. :)

https://codereview.chromium.org/2549083002/diff/1/src/counters.h
File src/counters.h (right):

https://codereview.chromium.org/2549083002/diff/1/src/counters.h#newcode696
src/counters.h:696: V(GetMoreDataCallback)                            \
Nitpick: Usually c < e, but I'm not sure if we're sorting case-insensitive here.

https://codereview.chromium.org/2549083002/diff/1/src/parsing/scanner-charact...
File src/parsing/scanner-character-streams.cc (right):

https://codereview.chromium.org/2549083002/diff/1/src/parsing/scanner-charact...
src/parsing/scanner-character-streams.cc:337: RuntimeCallTimerScope
scope(stats_, &RuntimeCallStats::GetMoreDataCallback);
Why does this compile without a new #include? I guess counters.h is included
somewhere from the include/v8.h or objects.h mega-headers?

Maybe in include-what-you-need fashion we should include this directly, in case
of later #include-cleanups?

https://codereview.chromium.org/2549083002/diff/1/src/parsing/scanner-charact...
src/parsing/scanner-character-streams.cc:648: // woByteExternalBufferedStream
Huh? (Editing error, I guess?)

[Toon Verwaest, 2016-12-05 15:18:46]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-12-05 15:18:47]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org,
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2549083002/#ps40001
(title: "Addressed comments")

[commit-bot: I haz the power, 2016-12-05 15:18:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 15:46:58]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480951126941470,
"parent_rev": "c5a7b11609769a8d3fc310b723209615b924a1d5", "commit_rev":
"fab2ead11f25b1bfd229d69af7e215290182355d"}

[commit-bot: I haz the power, 2016-12-05 15:47:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-05 15:47:20]

Description was changed from

==========
[counters] Move waiting for more data from background-parsing into callbacks

BUG=
==========

to

==========
[counters] Move waiting for more data from background-parsing into callbacks

BUG=

Committed: https://crrev.com/ce63eb08f9da8036693ec8f5198853033834f7d5
Cr-Commit-Position: refs/heads/master@{#41492}
==========

[commit-bot: I haz the power, 2016-12-05 15:47:21]

Patchset 3 (id:??) landed as
https://crrev.com/ce63eb08f9da8036693ec8f5198853033834f7d5
Cr-Commit-Position: refs/heads/master@{#41492}